qhexedit2 icon indicating copy to clipboard operation
qhexedit2 copied to clipboard

Performance loss when setting bytesPerLine too high

Open EvilGitty opened this issue 5 years ago • 3 comments

Setting the _bytesPerLine really high (in my case > 1000) results in a severe performance degradation. There is no performance loss when trying to set _bytesPerLine = 1 so everything is put into one column, instead of just one row.

My reason for this is that I want to enable the editor for other kinds of data representation - for example, I want to load an image but keep the spatial dimensions of the image in the editor (n rows, m columns).

So far, this editor is a great piece to work with!

EvilGitty avatar Mar 22 '19 09:03 EvilGitty

Does the suggestion #72 from @firexx solve your problem?

Simsys avatar Mar 22 '19 11:03 Simsys

I'm struggling to understand why there is decrasing performance when increasing the bytesPerLine. I understand that for rows only the visible ones are drawn but there seems to be no such consideration for cols/ bytes per line. Well, I will try to adapt and upload something.

EvilGitty avatar Mar 23 '19 11:03 EvilGitty

I think you're right. For lines it is calculated exactly which lines are visible and renderable. Such a mechanism is missing for columns. I didn't expect the use case to show so many columns. That's why many columns render a huge area unnecessarily.

Simsys avatar Mar 24 '19 15:03 Simsys