FSRN-CVPR2020
FSRN-CVPR2020 copied to clipboard
Found bug in "Fluid_wave_simulator"
Hello
Impressive work, thank you for publishing code @SimronThapa
I believe I might have found a bug in the fluid_simulator: https://github.com/SimronThapa/FSRN-CVPR2020/blob/fcae987dbd3a92de611a9a0c1c184f31961f48d7/Fluid_wave_simulator/getOceanWave.m#L14
While the WaveLimit, as defined in the paper "Simulating Ocean Water" by Jerry Tessendorf is:
This explains why visually pleasing results with the bug require using 200[m/s] wind speed.
So the correct code would be:
WaveLimit = L/100
Use L instead of Lx or Lz (Lx=Lz=PatchSize in the simulator code)
Best regards, Ori.