Simply-Love-SM5 icon indicating copy to clipboard operation
Simply-Love-SM5 copied to clipboard

Column Cue timer does not take machine offset into account

Open marysiamzawka opened this issue 1 year ago • 1 comments

While this isn't a real issue for most players, it can be noticable for players using extreme offset values (i.e. wireless setup players) and perhaps can throw them off.

Expected behaviour The timer appears in time to the notes regardless of the Machine Offset

Actual behaviour The timer doesn't appear in time relatively to the machine offset, resulting in delayed/premature countdown.

marysiamzawka avatar Mar 19 '23 20:03 marysiamzawka

There's actually this TODO for column cues to figure out why some of timings were offset: https://github.com/Simply-Love/Simply-Love-SM5/blob/release/BGAnimations/ScreenGameplay%20underlay/PerPlayer/ColumnCues.lua#L47-L48

I wonder if it's because of the global offset :O Will test this and see how it goes!

teejusb avatar Mar 23 '23 07:03 teejusb