Simply-Love-SM5 icon indicating copy to clipboard operation
Simply-Love-SM5 copied to clipboard

[Feature] flash column on bad judgment

Open aeubanks opened this issue 2 years ago • 1 comments

there's already an option to flash a column red if you get a miss there, adding an option to flash the column with the way off/decent color when you get one would be good for better feedback in regards to form.

or even more comprehensive would be to choose the bottom N judgments to flash on, up to excellents

aeubanks avatar Aug 13 '22 20:08 aeubanks

extremely jank local patch

diff --git a/BGAnimations/ScreenGameplay underlay/PerPlayer/ColumnFlashOnMiss.lua b/BGAnimations/ScreenGameplay underlay
/PerPlayer/ColumnFlashOnMiss.lua
index c9d5aa2..07f19fd 100644
--- a/BGAnimations/ScreenGameplay underlay/PerPlayer/ColumnFlashOnMiss.lua
+++ b/BGAnimations/ScreenGameplay underlay/PerPlayer/ColumnFlashOnMiss.lua
@@ -65,6 +65,12 @@ if mods.ColumnFlashOnMiss then
                                        if tns == "Miss" or tns == "MissedHold" then
                                                columns[column_mapping[i]]:playcommand("Flash")
                                        end
+                                       if tns == "W5" then
+                                               columns[column_mapping[i]]:playcommand("Flash2")
+                                       end
+                                       if tns == "W4" then
+                                               columns[column_mapping[i]]:playcommand("Flash3")
+                                       end
                                end
                        end
                end
@@ -80,14 +86,23 @@ if mods.ColumnFlashOnMiss then
                                        :vertalign(top)
                                        :setsize(width/NumColumns, _screen.h - y_offset)
                                        :fadebottom(0.333)
-               end,
+                       end,
                        FlashCommand=function(self)
-                               self:diffuse(1,0,0,0.66)
+                               -- self:diffuse(1,0,0,0.66)
+                               self:diffuse(SL.JudgmentColors[SL.Global.GameMode][6]):diffusealpha(0.66)
                                        :accelerate(0.165):diffuse(0,0,0,0)
-                       end
+                       end,
+                       Flash2Command=function(self)
+                               self:diffuse(SL.JudgmentColors[SL.Global.GameMode][5]):diffusealpha(0.66)
+                                       :accelerate(0.165):diffuse(0,0,0,0)
+                       end,
+                       Flash3Command=function(self)
+                               self:diffuse(SL.JudgmentColors[SL.Global.GameMode][4]):diffusealpha(0.66)
+                                       :accelerate(0.165):diffuse(0,0,0,0)
+                       end,
                }
        end

        return af

-end
\ No newline at end of file
+end

aeubanks avatar Aug 13 '22 20:08 aeubanks