Simply-Love-SM5
Simply-Love-SM5 copied to clipboard
Simply-Love
feature request: optionally turn off hearts in mod screen
I run StepMania 5 + Simply Love on a very old PC. Works great in gameplay - only problem I'm having is the scrolling hearts make the mod select screen laggy. It would be great if we could optionally turn these off.
The issue is likely due to the videos in the SRPG6 theme that plays in the background (regardless of if you actually have the SRPG6 visual theme selected). The current fix is to just remove this line:
https://github.com/Simply-Love/Simply-Love-SM5/blob/release/BGAnimations/_shared%20background/default.lua#L31
I'll fix it in the next release to make this a bit better for people.
I’m getting straight up memory leak from this issue. The theme just flat out crashes if I stay on SSM too long.
Also known. I think what's happening is that when a screen changes we're reloading the video with self:Load() (could be done better but my bad). Normally I wouldn't think that be an issue in of itself, but my assumption is that there's something happening in the engine where it isn't freeing the loaded video and instead just creating a new object. Was going to take a look into the exact cause when I have a chance in the upcoming weeks. The same aforementioned fix should help for the time being.
@natano I did not try that, but I can. I'll give it a try in the next day or two.
@teejusb I'll try this work around. Thanks! To clarify, I am not using "SRPG6" - unless that's the default, which I don't think it is. I'm just looking to play some basic custom charts, that sort of thing.
@Horsey- I haven't actually left this machine running for more than about 30 minutes so far, so I'm not sure if I'm also having this issue, but I can find out.
In general, I don't think this is an issue for most users. I'm amazed how well SM5 runs on a generic Dell machine from the mid 2000s (running Ubuntu, which seems to fair a little better than the windows 7 that shipped with it).
Also known. I think what's happening is that when a screen changes we're reloading the video with
self:Load()(could be done better but my bad). Normally I wouldn't think that be an issue in of itself, but my assumption is that there's something happening in the engine where it isn't freeing the loaded video and instead just creating a new object. Was going to take a look into the exact cause when I have a chance in the upcoming weeks. The same aforementioned fix should help for the time being.
I can confirm this is an engine issue with OutFox and not the theme. I've submitted several bug reports in the past which led to some sort of ffmpeg leak being fixed but the same bad behavior had remained when loading/unloading videos in a Sprite actor. Mac/Linux users won't notice this until much later due to the 64-bit binaries being able to address more virtual memory than Windows, the latter quickly crashes past the 900MB mark.
