Simply-Love-SM5 icon indicating copy to clipboard operation
Simply-Love-SM5 copied to clipboard

Published 20 hours ago • verified publisher icon Simply-Love

Support for Step Statistics in Ultrawide Double

Open Roujo opened this issue 3 years ago • 4 comments

Lots of values are arbitrary and hardcoded, but this looks pretty okay.

image

What's missing is QA and code review. The test cases I'll have to go through are combinations of the following:

Resolutions:

  • Ultrawide
  • 16:9
  • 4:3

Styles:

  • P1 Single
  • P1 Centered Single
  • P1 Double
  • P2 Single
  • P2 Centered Single
  • P2 Double
  • P1 + P2 (Versus)

Game Modes:

  • Pump It Up Support, since the notefield is larger. Do we want to support and test this as well?

Roujo avatar Dec 28 '21 23:12 Roujo

I should also mention that I added a scorebox to step stats in https://github.com/Simply-Love/Simply-Love-SM5/pull/345 . Can you verify that the positioning/sizing is still correct (you'll need to use the launcher to check this)?

teejusb avatar Jan 02 '22 08:01 teejusb

I should also mention that I added a scorebox to step stats in #345 . Can you verify that the positioning/sizing is still correct (you'll need to use the launcher to check this)?

Yup, will do! ^^

Roujo avatar Jan 27 '22 01:01 Roujo

Is this PR still in progress or should I close?

teejusb avatar Dec 13 '23 18:12 teejusb

I haven't looked into doing the required QA in a while, but it is a feature I'd like to see in SL so I'll put that back on my plate, thank you for the reminder! 😄

(Wow, it's been 2 years, incredible 🤣)

Roujo avatar Dec 13 '23 22:12 Roujo