SMF icon indicating copy to clipboard operation
SMF copied to clipboard

[3.0] Update quick modify to support Ctrl+Enter

Open live627 opened this issue 4 months ago • 5 comments

live627 avatar Aug 26 '25 10:08 live627

Just for clarification, why are we removing tabindex?

jdarwood007 avatar Aug 26 '25 21:08 jdarwood007

As a rule, we should keep the tabindex attribute itself, but we should set its value to 0 everywhere:

Warning: You are recommended to only use 0 and -1 as tabindex values. Avoid using tabindex values greater than 0 and CSS properties that can change the order of focusable HTML elements (Ordering flex items). Doing so makes it difficult for people who rely on using keyboard for navigation or assistive technology to navigate and operate page content. Instead, write the document with the elements in a logical sequence.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Global_attributes/tabindex

Sesquipedalian avatar Aug 26 '25 22:08 Sesquipedalian

As a rule, we should keep the tabindex attribute itself, but we should set its value to 0 everywhere:

Warning: You are recommended to only use 0 and -1 as tabindex values. Avoid using tabindex values greater than 0 and CSS properties that can change the order of focusable HTML elements (Ordering flex items). Doing so makes it difficult for people who rely on using keyboard for navigation or assistive technology to navigate and operate page content. Instead, write the document with the elements in a logical sequence.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Global_attributes/tabindex

According to the tabindex spec, there is no need to specify it to 0, since some elements have 0 as a default:

https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex

frandominguezl avatar Sep 06 '25 09:09 frandominguezl

Screen Shot 2025-09-14 at 3 42 45 PM

I get an error 500 when I try to save the quick edit. Also, get a js error for length. The js error is because of the error 500 and it isn't handling the error properly.

The error 500 is related to a diff error. This is synced up to the current revision, correct?

jdarwood007 avatar Sep 14 '25 22:09 jdarwood007

@live627, You still working on this?

jdarwood007 avatar Oct 26 '25 17:10 jdarwood007