SMF icon indicating copy to clipboard operation
SMF copied to clipboard

Drop single dimensional array support for data array in insert function

Open albertlast opened this issue 1 year ago • 2 comments

Since it bugged since 2.1 -> no one mention the issue, we could drop the feature and make the interface more clear.

albertlast avatar Jul 06 '24 06:07 albertlast

nope, not ready for thsi major breaking change because this ends up breaking half of the entire application, let alone third party mods.

live627 avatar Jul 06 '24 07:07 live627

maybe you didn't read the mayor point, but it doesn't work atm. Or miss i something?

albertlast avatar Jul 06 '24 08:07 albertlast

How is it bugged? Can I have an example?

live627 avatar Dec 25 '24 04:12 live627

Checking only one random element in $data makes no sense. I think @albertlast is correct that the current code could cause bugs.

However, the solution is not to just remove this code. Instead, we should check all the elements in $data to make sure that all the elements in $data are as expected.

Sesquipedalian avatar Feb 02 '25 21:02 Sesquipedalian