SMF icon indicating copy to clipboard operation
SMF copied to clipboard

[2.1, 3.0]: Wrong position for $context['error_code'] in template

Open dragomano opened this issue 1 year ago • 3 comments

Basic Information

Errors.template.php, function template_fatal_error:

<div ', $context['error_code'], 'class="padding">

Result HTML (for example, on 404 error):

<div 404class="padding">

As a result, the padding class is not recognized and does not work.

Steps to reproduce

  1. Open non-exist action
  2. Open browser's devtools and select the message block

Expected result

<div class="padding">

or maybe

<div class="padding error_404">

Actual result

<div 404class="padding">

Version/Git revision

2.1.4, 3.0 Alpha 1

Database Engine

MySQL

Database Version

MariaDB-10.6.11

PHP Version

8.0.30

Logs

No response

Additional Information

No response

dragomano avatar Jan 27 '24 16:01 dragomano

@DiegoAndresCortes and @TwitchisMental, Can you add this to the theme PR (#7933)?

jdarwood007 avatar Jan 28 '24 16:01 jdarwood007

Can you assign it to me I'll check it in a few weeks

DiegoAndresCortes avatar Jan 28 '24 17:01 DiegoAndresCortes

Minor version is inverted in title of the issue btw

DiegoAndresCortes avatar Jan 29 '24 17:01 DiegoAndresCortes