SMF icon indicating copy to clipboard operation
SMF copied to clipboard

[3.0] Add an option for cdnjs to jQuery CDNs

Open Oldiesmann opened this issue 1 year ago • 5 comments

This PR adds built-in support for loading jQuery from Cloudflare's CDN (aka "cdnjs"). While it doesn't add any additional benefits, it gives us another solid option in addition to the ones provided.

Oldiesmann avatar Jan 06 '24 04:01 Oldiesmann

We implemented cloudflare cdn in #7933 when adding fontawesome, we can add it to jquery there

DiegoAndresCortes avatar Jan 06 '24 23:01 DiegoAndresCortes

@DiegoAndresCortes, would you prefer yours or Oldies then? If you want yours, closeout and merge the theme one later.

At another layer. I think we need to abstract the CDN logic. So it's easy to add more providers in the future or remove them. As well as identify which files they can serve, then allow passing or grabbing which 'version' they should be using as defined by our software. A "local" provider is always the SMF install.

jdarwood007 avatar Jan 08 '24 00:01 jdarwood007

Personally, I think it would be best to push this to alpha 4 when the other template changes are targeted.

tyrsson avatar Jan 09 '24 21:01 tyrsson

The only theme-related files this touches are a couple of language files. It doesn't modify the templates at all.

Oldiesmann avatar Jan 11 '24 02:01 Oldiesmann

Both PR's need to wait for #7853 anyways so will just have to wait and decide later.

DiegoAndresCortes avatar Jan 11 '24 03:01 DiegoAndresCortes