SMF icon indicating copy to clipboard operation
SMF copied to clipboard

Restore showing profile areas added with `integrate_profile_areas`

Open live627 opened this issue 3 years ago • 0 comments

integrate_profile_areas should work (retain functionality from 2.0). The problem is that the changed array is lost when createMenu() exits, so that the calling code in Profile.php thinks that nothing happened.

What this PR does

  • Move the hook point from createMenu() to Profile() (like it was in 2.0 which I think is proper).
  • Deprecate integrate_pre_profile_areas because it is unused now.
  • Add a new menu option disable_hook_call to make this work right.

Alternative fix

Pass $menuData as a reference

Related issues

  • https://github.com/SimpleMachines/SMF/issues/3118
  • https://github.com/SimpleMachines/SMF/issues/3145
  • https://github.com/SimpleMachines/SMF/issues/3945

live627 avatar Jul 09 '22 07:07 live627