added mem.real_name to group by

[albertlast]

extraced the group by logic in a own var, with the hope that it better is to read, instead of compress more logic into this inline.

fixes: #7508

tested in pg

[live627]

What are your thoughts on changing the sort to pm.from_name and leaving the GROUP BY alone? This way I think it can sort guests, too.

[albertlast]

dunno from ux side, on programm side we could drop the join in this case, i guess. so would be faster.

[live627]

sounds good

On Mon, Jul 11, 2022 at 7:01 AM albertlast @.***> wrote:

dunno from ux side, on programm side we could drop the join in this case, i guess. so would be faster.

— Reply to this email directly, view it on GitHub https://github.com/SimpleMachines/SMF/pull/7517#issuecomment-1180446973, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADJNN37NYOA2WQL3S46MNTVTQSLZANCNFSM52QFSKHQ . You are receiving this because you commented.Message ID: @.***>

[sbulen]

I have tested this & it works.

I actually don't think the idea of using pm.from_name will work, because depending on whether you're looking at the inbox or the sent folder, the join to mem is different... It's not the from_name when looking at the sent folder, which is what is failing here.

Make sense?