Consistently use (fs) "directory" and (mail) "folder"

[m4z]

I'd like to consistently use "directory" for the filesystem object and "folder" for mailboxes, for easier translation and glossary creation.

The only mail-related mention of "folder" I could find is $txt['activate_after_registration'].

Some strings (or variable names) use "folder" instead of directory:

• $txt['attach_repair_wrong_folder'] (name)
• $txt['attach_folder_warning'] (name)
• $txt['attach_folder_admin_warning'] (name)
• $txt['package_get_error_is_zero'] (content)
• $helptxt['avatar_server_stored'] (content)
• $txt['package_file_perms_desc'] (content)
• $helptxt['attachmentUploadDir'] (content)
• $helptxt['attachmentDirSizeLimit'] (content)
• $helptxt['automanage_attachments'] (content)
• $helptxt['image_proxy_maxsize'] (content)
• $txt['error_agreement_not_writable'] (content)
• $txt['smiley_set_unused'] (content)
• $txt['theme_install_error_file_6'] (content)

Is this a reasonable proposal, or are there reasons to use both?

[DiegoAndresCortes]

For the future too as it would be best to also change the name of the myriad of variables inconsistently using folder/directory and vice versa

[m4z]

I agree this isn't urgent.