Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Port Ghost Bar

Open VMSolidus opened this issue 1 year ago • 4 comments

Description

This PR ports https://github.com/Goob-Station/Goob-Station/pull/454 By popular request from our Downstreams

About the PR

Adds ghost bar :) Resolves #453

TODO:

* [x]  Spawn ghost map bar on round start

* [x]  Add button to ghost UI to spawn at ghost bar

* [x]  Warning popup before spawning

* [x]  Only allow players to spawn once to prevent them from creating piles of bodies (or delete their old body first?)

* [x]  Cleanup map.

Media

2024-08-02.01-38-29.mp4

* [x]  I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase

Changelog 🆑

* add: Ghost bar!

Media

https://github.com/user-attachments/assets/de3cfb4b-e35c-453e-903c-ba96f15da101

Changelog

:cl:

  • add: Ghost Bar has been ported from Goob Station

VMSolidus avatar Sep 11 '24 02:09 VMSolidus

Put the original PR's media in your description.

DEATHB4DEFEAT avatar Sep 11 '24 02:09 DEATHB4DEFEAT

Put the original PR's media in your description.

done

VMSolidus avatar Sep 11 '24 02:09 VMSolidus

Thunderdome next for the station to watch ghosts fight it out? :)

Peptide90 avatar Sep 18 '24 10:09 Peptide90

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 04 '24 00:10 github-actions[bot]

Thunderdome next for the station to watch ghosts fight it out? :)

Bad idea, putting ghost players in the same map as the station will always lead to them finding ways to break out.

I do plan on adding onto ghost bar in the future, giving it a secondary section with a gladiator arena that the ghost bar people can watch. The main bar everyone will spawn with pacifism, the gladiator arena people will spawn with random combat loadouts.

Aidenkrz avatar Oct 20 '24 07:10 Aidenkrz

I may modify this myself to fix it.

Aidenkrz avatar Oct 20 '24 07:10 Aidenkrz

Thunderdome next for the station to watch ghosts fight it out? :)

Bad idea, putting ghost players in the same map as the station will always lead to them finding ways to break out.

I do plan on adding onto ghost bar in the future, giving it a secondary section with a gladiator arena that the ghost bar people can watch. The main bar everyone will spawn with pacifism, the gladiator arena people will spawn with random combat loadouts.

THUNDERDOME! :) It's red vs blue if you don't know where the players select their loadouts and battle it out with hammers and swords and stuff. Then link back to the station for people to watch.

Peptide90 avatar Oct 27 '24 09:10 Peptide90

Thunderdome next for the station to watch ghosts fight it out? :)

Bad idea, putting ghost players in the same map as the station will always lead to them finding ways to break out. I do plan on adding onto ghost bar in the future, giving it a secondary section with a gladiator arena that the ghost bar people can watch. The main bar everyone will spawn with pacifism, the gladiator arena people will spawn with random combat loadouts.

THUNDERDOME! :) It's red vs blue if you don't know where the players select their loadouts and battle it out with hammers and swords and stuff. Then link back to the station for people to watch.

I actually already designed most of it, with a gladiator role/loadout + handheld TVs and body cams Only issue that i hate is that i couldn't figure out how to get device networks to work across grids, Frontier peeps might know more about it

Aidenkrz avatar Oct 31 '24 02:10 Aidenkrz

ragh!! the arcade machines should be rotated unless the media is just outdated

bruhmogus avatar Nov 09 '24 17:11 bruhmogus

when?

PuroSlavKing avatar Nov 23 '24 14:11 PuroSlavKing

+1

v0idRift avatar Nov 23 '24 20:11 v0idRift

As the person who made this, ghost bar has some issues that need to be fixed before it should be merged. For some reason, this carries over the identity of the player completely, so if someone has a kill objective on the player, and they respawn at ghost bar, it will mark as failed. It's probably an easy fix, but i haven't bothered to look into it.

Checking out how objectives identify a target as dead should reveal how to fix it.

This was fixed on goob btw

Aidenkrz avatar Dec 02 '24 20:12 Aidenkrz

Wouldn't it be better to make it look like a ghost role rather than a button? Like in Blue Moon server in SS13

BL02DL avatar Dec 22 '24 09:12 BL02DL

Already implemented in https://github.com/Simple-Station/Einstein-Engines/pull/1675, closing

angelofallars avatar Jan 31 '25 08:01 angelofallars