Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Mirror: Add stealthmins

Open SimpleStation14 opened this issue 9 months ago • 0 comments

Mirror of PR #26263: Add stealthmins from space-wizards space-wizards/space-station-14

dca0c6694bce56fcf962feab2b59ad4a849f4533

PR opened by nikthechampiongr at 2024-03-19 16:14:22 UTC


PR changed 11 files with 197 additions and 10 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

resolve #26013

About the PR

This pr implements stealthmins as laid out in issue #26013.

There is now the Stealth permission flag. This allows admins to use the stealthmin command and to see other stealthmins.

When stealthmin is toggled, the admin will not show up in adminwho except for other admins with the Stealth permission.

The stealthmin command sends fake de-admin/re-admin messages to admins without the Stealth flag.

stealthmin persists in the same way deadmin does(it persists for the lifetime of the server).

Admin login/logout messages are suppressed for stealthmins except for other admins with the Stealth flag.

It is still possible possible to find stealthed admins using toolshed commands or logs. This is in line with the requirements of the issue, and I don't want to start clobbering functionality of logs and toolshed.

Why / Balance

See #26013

Technical details

Stealth flag now exist for AdminFlags.

An admin's stealth status is saved in their admin registration and in ContentData.

SendAdminAnnouncement now takes a whitelist flag and blacklist flag (This will work with multiple flags). This is necessary to suppress admin announcements where necessary. Blacklist takes priority over whitelist.

Media

https://github.com/space-wizards/space-station-14/assets/32041239/98ec48c3-170e-406a-b177-07003ff7d59f

  • [x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: ADMIN:

  • add: The stealthmin command has been added. Admins with the Stealth permission can now hide themselves from adminwho except for other admins with that permission.

SimpleStation14 avatar May 03 '24 15:05 SimpleStation14