Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Failed to cherry-pick PR #26103: Drink from closed container fix

Open SimpleStation14 opened this issue 10 months ago • 0 comments

Failed to cherry-pick PR: cannot push non-fastforwardable reference; class=Reference (4); code=NotFastForward (-11)

PR body below

Mirror of PR #26103: Drink from closed container fix from space-wizards space-wizards/space-station-14

2f2cd4aab70703717541e5db3f46ae4831b4129d

PR opened by maylokana at 2024-03-14 03:59:47 UTC


PR changed 1 files with 3 additions and 0 deletions.

The PR had the following labels:


Original Body

About the PR

All drink containers now check if the container is closed once the do-after is done, and will stop you from trying to drink from it if it is closed

Why / Balance

Bug fix. I think

Technical details

In DrinkSystem.cs, added an _openable.IsClosed() method to OnDoAfter(), which returns if true

Media

https://github.com/space-wizards/space-station-14/assets/88361930/cf983879-5073-407a-98fc-2004692a8d08

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A

Changelog

:cl:

  • fix: Entities can no longer drink from closed containers

SimpleStation14 avatar Apr 22 '24 22:04 SimpleStation14