Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Published 20 hours ago • verified publisher icon Simple-Station

Mirror: Code Cleanup: Purge obsolete MapManager methods

Open SimpleStation14 opened this issue 10 months ago • 1 comments

Mirror of PR #26279: Code Cleanup: Purge obsolete MapManager methods from space-wizards space-wizards/space-station-14

ae3d745430e3c5250d19553429e7cda2b8050d10

PR opened by Tayrtahn at 2024-03-20 02:51:49 UTC

PR changed 49 files with 97 additions and 122 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

Cleans up some obsolete method calls.

Why / Balance

This is definitely low -hanging fruit on the code cleanup tree, but clearing out compiler warnings is always nice.

Technical details

Removes every use of obsolete MapManager methods (GetGrid, GridExists, and TryGetGrid), replacing them with appropriate EntityManager methods or their corresponding EntitySystem extension methods.

Media

Code

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

SimpleStation14 avatar Apr 22 '24 09:04 SimpleStation14