Failed to cherry-pick PR #26238: Code cleanup: Dirty(Comp)

[SimpleStation14]

Failed to cherry-pick PR: cannot create a tree from a not fully merged index.; class=Index (10); code=Unmerged (-10)

PR body below

Mirror of PR #26238: Code cleanup: Dirty(Comp) from space-wizards/space-station-14

4a83c365858830e3b2ff2b94fff501256422c20e

PR opened by Tayrtahn at 2024-03-18 16:56:10 UTC

---

PR changed 74 files with 245 additions and 249 deletions.

The PR had the following labels:

• Status: Needs Review

---

Original Body

About the PR

Replaced all uses of Dirty(Component) with Dirty(Uid, Component) in content.

Why / Balance

Over 100 compiler warnings removed.

Technical details

Some systems had to be modified to pass around uids internally. ~Notably, the (numerous) systems related to pulling relied on passing and tracking components, so they were modified a bit to be more based around uids. Those systems definitely could still use a refactor, but that was not the intention of this PR. This just changes what needed to be changed to get uids tracked (and maybe a teensy bit more to be consistent).~

I did test as many aspects of this as I could. However, this PR makes (mostly small) changes to a bunch of different systems, so be prepared to do some triage if this gets merged. Everything worked fine for me, and most potential issues would just be client mispredictions, but I'm not going to pretend that I was able to think of and test every possible edge case.

Media

Code.

• [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

The public APIs for TagSystem and SharedInstrumentSystem have changed to require EntityUid parameters for more methods. Systems that call these methods will need to be updated.

Changelog

Not today