Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Cleaning Up Unnecessary Folders

Open Spatison opened this issue 4 months ago • 4 comments

Description

A large number of unnecessary folders greatly clutters the project space and interferes with project forks. Ideally, it is worth removing all folders with _ at the beginning and leaving only _EE. This PR only removes duplicate server folders.

_White -> WhiteDream _DV -> DeltaV _Imp -> _impstation _CS4875 - Migrated to Nyanotrasen (What is this anyway?) _TG - Migrated to _EE. (This isn't even SS14) _SimpleStation - Migrated to root folder. Content.GoobStation -> _Goobstation


Changelog

no cl

Spatison avatar Aug 01 '25 06:08 Spatison

Walkthrough

This set of changes standardizes namespaces and resource paths by removing underscore prefixes across C#, YAML, and localization files. It adds new modsuit items and their catalog entries, updates related localization and sprite paths, and introduces a new game event entity. Several redundant or outdated files and references are removed for consistency.

Changes

Cohort / File(s) Change Summary
Namespace Standardization – DeltaV & WhiteDream
Content.Client/DeltaV/Salvage/UI/MiningVoucherBoundUserInterface.cs, Content.Client/DeltaV/Salvage/UI/MiningVoucherMenu.xaml.cs, Content.Client/DeltaV/SmartFridge/SmartFridgeBoundUserInterface.cs, Content.Client/DeltaV/SmartFridge/SmartFridgeItem.xaml.cs, Content.Client/DeltaV/SmartFridge/SmartFridgeMenu.xaml.cs, Content.Client/DeltaV/SmartFridge/SmartFridgeUISystem.cs, Content.Server/DeltaV/StationEvents/Components/ThavenMoodUpsetRuleComponent.cs, Content.Server/DeltaV/StationEvents/Events/ThavenMoodUpset.cs, Content.Shared/DeltaV/Salvage/Components/MiningVendorComponent.cs, Content.Shared/DeltaV/Salvage/Components/MiningVoucherComponent.cs, Content.Shared/DeltaV/Salvage/MiningVoucherUI.cs, Content.Shared/DeltaV/Salvage/Systems/MiningVoucherSystem.cs, Content.Shared/DeltaV/SmartFridge/SmartFridgeComponent.cs, Content.Shared/DeltaV/SmartFridge/SmartFridgeSystem.cs
Updated namespaces and using directives from underscore-prefixed to dot-separated (e.g., _DVDeltaV). No logic changes.
Namespace Standardization – Impstation/WhiteDream
Content.Server/_Impstation/Drone/DroneComponent.cs, Content.Server/_Impstation/Drone/DroneSystem.cs, Content.Shared/_Impstation/Drone/SharedDroneSystem.cs, Content.Server/WhiteDream/Blocking/RechargeableBlockingComponent.cs, Content.Server/WhiteDream/Blocking/RechargeableBlockingSystem.cs, Content.Shared/WhiteDream/Grab/GrabThrownComponent.cs, Content.Shared/WhiteDream/Grab/GrabThrownSystem.cs, Content.Client/WhiteDream/ItemSlotRenderer/ItemSlotRendererComponent.cs, Content.Client/WhiteDream/ItemSlotRenderer/ItemSlotRendererSystem.cs
Changed namespaces from underscore-prefixed to dot-separated (e.g., _Imp_Impstation, _WhiteWhiteDream). Removed unused using directives.
Drone and Grab System Namespace Adjustments
Content.Server/Silicons/Borgs/BorgSystem.Transponder.cs, Content.Server/_Goobstation/Devil/Contract/DevilContractSystem.cs, Content.Shared/Movement/Pulling/Systems/PullingSystem.cs, Content.Shared/_Goobstation/MartialArts/SharedMartialArtsSystem.cs
Updated using directives to new namespace paths for Drone and Grab systems. No logic changes.
Entry Point and Overlay
Content.Client/Entry/EntryPoint.cs
Removed an unused using directive and a comment marker. No functional changes.
Modsuit Additions and Catalog
Resources/Prototypes/_EE/Catalog/uplink_catalog.yml, Resources/Locale/en-US/_EE/store/uplink-catalog.ftl
Added two modsuit entries (BloodRedModsuit, SyndicateEliteModsuit) to the uplink catalog and corresponding localization entries.
Modsuit Sprite Path Updates
Resources/Prototypes/_EE/Entities/Clothing/Modsuits/SyndicateModsuits.yml
Changed all modsuit sprite paths from _TG/Clothing/Modsuit/ to _EE/Clothing/Modsuit/.
Localization and Catalog Removals
Resources/Locale/en-US/_TG/store/uplink-catalog.ftl, Resources/Prototypes/_TG/uplink_catalog.yml
Removed old modsuit localization and catalog files for the TG variant.
Game Event Entity Relocation
Resources/Prototypes/DeltaV/GameRules/events.yml, Resources/Prototypes/_DV/GameRules/events.yml
Moved the ThavenMoodUpset event entity from _DV to DeltaV, updating its definition and location.
Sprite Path Adjustments – Alerts and Markings
Resources/Prototypes/Alerts/alerts.yml, Resources/Prototypes/DeltaV/Entities/Mobs/Customization/Markings/thaven.yml, Resources/Prototypes/Entities/Mobs/Customization/Markings/ipc_wings.yml, Resources/Prototypes/_Impstation/Drone/Mobs_Player_silicon.yml, Resources/Prototypes/_Impstation/Drone/drone_tools.yml, Resources/Prototypes/Recipes/Crafting/bots.yml, Resources/Prototypes/WhiteDream/Shaders/shaders.yml
Updated sprite and shader resource paths to remove underscores and standardize directory naming.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

Changes: C#, Changes: YML, Status: Needs Review

Suggested reviewers

  • Remuchi
  • sleepyyapril
  • Timfa2112

Poem

Oh, the barracks are spotless, the namespaces tight,
No Sol Alliance chaos to be found in sight!
Modsuits gleam, their icons aligned,
Catalogs and sprites now properly assigned.
From WhiteDream to DeltaV, the order’s restored—
The Republic’s codebase, sharp as a sword!
🛡️✨


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a650fba40ade29c6a4e954daf2bdd4506460bc6 and 652d75897f8d75af5130bfd6e95d6ce11ec4e503.

⛔ Files ignored due to path filters (2)
  • Resources/Textures/Clothing/Head/Hardsuits/paramedhelm.rsi/equipped-HELMET-vulpkanin.png is excluded by !**/*.png, !Resources/Textures/** and included by none
  • Resources/Textures/Clothing/OuterClothing/WinterCoats/coatwarden.rsi/equipped-OUTERCLOTHING-vox.png is excluded by !**/*.png, !Resources/Textures/** and included by none
📒 Files selected for processing (1)
  • Resources/Prototypes/Entities/Mobs/Customization/Markings/plasmaman_wings.yml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • Resources/Prototypes/Entities/Mobs/Customization/Markings/plasmaman_wings.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Test Packaging
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: YAML Linter
✨ Finishing Touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 01 '25 06:08 coderabbitai[bot]

This would make porting stuff from other codebases harder. The most ideal solution would be the adoption of goob style projects. As for prototypes, this would increase collision likelihood with Wizard's.

astriloqua avatar Aug 09 '25 13:08 astriloqua

why do goob, imp, and ee keep the _?

DEATHB4DEFEAT avatar Sep 20 '25 20:09 DEATHB4DEFEAT

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 17 '25 03:10 github-actions[bot]