Port Devil
Description
This PR ports https://github.com/Goob-Station/Goob-Station/pull/2409 https://github.com/Goob-Station/Goob-Station/pull/2591 https://github.com/Goob-Station/Goob-Station/pull/2599
This PR was initially intended to be merged into White Dream repo, so my changes are marked as WD edit.
TODO
- [ ] Port pain numbness
- [ ] Port nullrods
- [ ] Port tile movement
Media
Changelog
:cl:
- add: Ported Devil antag from Goobstation
Walkthrough
A comprehensive "Devil" antagonist system has been introduced, including new C# systems, components, events, and extensive YAML prototypes for contracts, abilities, objectives, and items. Supporting mechanics for possession, cheat death, condemnation, holy/unholy interactions, and divine interventions are added. Numerous localization files and guidebook entries expand player-facing content.
Changes
| File(s) / Path(s) | Change Summary |
|---|---|
| Content.Client/Content.Client.csproj, Content.Server/Content.Server.csproj | Added new folder paths for Devil and UI systems to project structure. |
| Content.Server/Administration/Systems/AdminVerbSystem.Antags.cs | Added "make devil" admin verb for antagonist management. |
| Content.Server/Bible/BibleSystem.cs | Simplified return statement formatting. |
| Content.Server/Chat/SuicideSystem.cs | Prevented suicide for entities tagged with "CannotSuicideAny". |
| Content.Server/DeltaV/Paper/SignatureSystem.cs | Enhanced paper signing logic to support DevilComponent, TrueName, and event-based signing restrictions. |
| Content.Server/Morgue/CrematoriumSystem.cs | Skipped deletion of entities with CrematoriumImmuneComponent during cremation. |
| Content.Server/WhiteDream/BloodCult/Constructs/SoulShard/SoulShardSystem.cs, Content.Server/WhiteDream/BloodCult/Runes/CultRuneBaseSystem.cs | Added using directives for shared Bible logic. |
| Content.Server/_Goobstation/Devil/** | Introduced full Devil antagonist system: core, actions, handshake, contract logic, condemned/death/possession/roles/objectives, grip, UI messages, and supporting components. |
| Content.Server/_Goobstation/Possession/** | Added possession system and component, handling mind transfers, polymorphing, and feedback. |
| Content.Server/_Goobstation/TeleportOnStateChange/** | Added teleport-on-mob-state-change component and system. |
| Content.Server/_Shitmed/DelayedDeath/** | Refactored delayed death system, added custom popup messages, and improved defibrillator interaction handling. |
| Content.Shared/Damage/Components/PassiveDamageComponent.cs | Enabled auto network state for passive damage component. |
| Content.Shared/Magic/SharedMagicSystem.cs | Added event-based touch spell denial logic. |
| Content.Shared/_Goobstation/Bible/** | Moved BibleComponent to shared, added smite damage/stun, and introduced GoobBibleSystem for holy interactions. |
| Content.Shared/_Goobstation/CrematorImmune/CrematorImmuneComponent.cs | Added crematorium immunity component. |
| Content.Shared/_Goobstation/Dash/CheatDeath/CheatDeathComponent.cs | Added networked CheatDeathComponent and event. |
| Content.Shared/_Goobstation/DelayedDeath/DelayedDeathEvent.cs | Added delayed death event struct. |
| Content.Shared/_Goobstation/Devil/** | Introduced all shared Devil components, contract logic, events, power levels, handshake, UI messages, and objective tracking. |
| Content.Shared/_Goobstation/Enchanting/Systems/EnchantSacrificeSystem.cs | Added (commented-out) system for enchanting upgrades via sacrifice. |
| Content.Shared/_Goobstation/Exorcism/ExorcismDoAfter.cs | Added exorcism do-after event. |
| Content.Shared/_Goobstation/Paper/BeingSignedAttemptEvent.cs, Content.Shared/_Goobstation/Paper/SignSucessfulEvent.cs | Added events for paper signing attempts and successes. |
| Content.Shared/_Goobstation/Possession/PossessionEvents.cs | Added event for ending possession early. |
| Content.Shared/_Goobstation/Religion/** | Added divine intervention, unholy/holy components, spell denial, and weak-to-holy logic. |
| Resources/Locale/en-US/_Goobstation/, Resources/Locale/en-US/_Shitmed/ | Added extensive localization for Devil, contracts, cheat death, grip, condemned, possession, currency, and new items. |
| Resources/Prototypes/Damage/containers.yml | Added "Holy" damage type, reorganized containers, and introduced new containers for metaphysical and spirit damage. |
| Resources/Prototypes/Entities/Mobs/Player/jaunt_mobs.yml, observer.yml | Added jaunt mob prototypes and UI for revival contracts. |
| Resources/Prototypes/Entities/Objects/Fun/figurine_boxes.yml, figurines.yml | Added Devil figurine and dataset. |
| Resources/Prototypes/Entities/Objects/Misc/paper.yml, pen.yml | Added advanced pen, futuristic/devilish pen, and enhanced pen melee/tool features. |
| Resources/Prototypes/GameRules/roundstart.yml, _Goobstation/GameRules/roundstart.yml | Enabled Devil as a possible subgamemode and defined Devil game rule entity. |
| Resources/Prototypes/Guidebook/antagonist.yml, _Goobstation/Guidebook/devil.yml | Added Devil and Changeling to antagonist guide, provided Devil guidebook entries and clause references. |
| Resources/Prototypes/Roles/Jobs/Civilian/chaplain.yml, lawyer.yml, Command/captain.yml | Added Condemned component to Chaplain, Lawyer, and Captain jobs. |
| Resources/Prototypes/Roles/MindRoles/mind_roles.yml | Cosmetic: added comment and blank line. |
| Resources/Prototypes/_Goobstation/Actions/devil.yml | Added new Devil action entities for contracts, possession, grip, cheat death, and more. |
| Resources/Prototypes/_Goobstation/Datasets/Names/devil_names.yml | Added datasets for devil-themed first and last names. |
| Resources/Prototypes/_Goobstation/Devil/clauses.yml | Added Devil contract clause definitions with various gameplay effects. |
| Resources/Prototypes/_Goobstation/Devil/contract.yml | Added devil contract item prototypes (blank, written, and revival variants). |
| Resources/Prototypes/_Goobstation/Devil/devilgrip.yml | Added DevilGrip item with multiple surgical tool components and effects. |
| Resources/Prototypes/_Goobstation/Devil/powerlevel.yml | Added DevilBranchPrototype for power level actions. |
| Resources/Prototypes/_Goobstation/Effects/fire.yml, pentagram.yml, helldrag.yml | Added fire, pentagram, and hell hand effect entities. |
| Resources/Prototypes/_Goobstation/Entities/Clothing/Shoes/boots.yml | Added Jordans shoes (pristine, creased, autographed variants) with unique stats and destruction behavior. |
| Resources/Prototypes/_Goobstation/Entities/Clothing/Uniforms/jumpsuits.yml | Added Devil jumpsuit with armor resistances. |
| Resources/Prototypes/_Goobstation/Entities/Mobs/NPCs/jaunt.yml | Added polymorph and animation entities for shadow jaunt ability. |
| Resources/Prototypes/_Goobstation/Entities/Objects/Misc/books.yml | Added Codex Umbra guidebook entity. |
| Resources/Prototypes/_Goobstation/Objectives/devilObjectives.yml | Added Devil objectives for contract signing. |
| Resources/Prototypes/_Goobstation/Polymorphs/polymorph.yml | Added/updated polymorph prototypes for Devil and related mechanics. |
| Resources/Prototypes/_Goobstation/Roles/Antags/devil.yml | Added Devil antagonist role and starting gear definition. |
Suggested labels
Changes: C#, Changes: Localization, Changes: UI, Changes: YML, Changes: Sprite, Status: Needs Review
Suggested reviewers
- Remuchi
- DEATHB4DEFEAT
- VMSolidus
- Timfa2112
Poem
⚓️
A devilish update sweeps the deck,
With contracts, claws, and shoes to wreck!
Possessions swirl, condemned now quake,
Cheat death, jaunt shadows, for evil’s sake.
The guidebook swells, the sprites ignite,
Tau Ceti’s code shines devil-bright.
Sol’s errors beware—our review is tight!
🦑
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
RP antag = nice <3
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.