ABSTRACT FLOAT

[VMSolidus]

Description

I just wanted to get this madness out of my head. Nothing is actually using these yet, but they'll be more useful when I get around to making modular actions and such. Did you know that you can overload abstract types?

Changelog

No CL this isn't player facing. Yet.

[coderabbitai[bot]]

Walkthrough

A new file introduces an abstract class hierarchy for contest evaluation functions, defining a base ContestFunction and specialized subclasses for Mass, Stamina, Health, Mind, and Mood contests. Each subclass implements comparator methods for single or double entity evaluations, with some including additional configurable fields for contest calculations.

Changes

File(s)	Change Summary
Content.Shared/Contests/ContestsSystem.Functions.cs	Added new file defining ContestFunction abstract base class and specialized abstract subclasses for various contest types (Mass, Stamina, Health, Mind, Mood), each implementing comparator logic for single or double entity scenarios.

Poem

⚓️
In Tau Ceti’s code review bay,
New contests now hold sway.
Mass, Mind, Mood—each with a rule,
No Sol Alliance hacks to fool!
Abstract and clean, the functions parade,
Biesel’s standards—never to fade.
🛡️

[!NOTE]

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Learn more here.

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e992284590962d69008489542c67214fff9a4560 and 4b19b553a2cb47be0e3185bfdd539e595945d5d8.

📒 Files selected for processing (1)

• Content.Shared/Contests/ContestsSystem.Functions.cs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Content.Shared/Contests/ContestsSystem.Functions.cs

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: build (ubuntu-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: YAML Linter
• GitHub Check: Test Packaging
• GitHub Check: YAML map schema validator

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[VMSolidus]

I'll revisit this nonsense at another time.