Einstein-Engines
Einstein-Engines copied to clipboard
Simple-Station
Failed to cherry-pick PR #26217: Fix pressure damage calculations
Failed to cherry-pick PR: mainline branch is not specified but 153d2815fc84b31c64a611736aaf538c45a3f3dd is a merge commit; class=CherryPick (27)
PR body below
Mirror of PR #26217: Fix pressure damage calculations from 
space-wizards/space-station-14
153d2815fc84b31c64a611736aaf538c45a3f3dd
PR opened by 
PR changed 3 files with 55 additions and 59 deletions.
The PR had the following labels:
- Status: Needs Review
Original Body
About the PR
Pressure damage calculations were wrong. They were originally ported from TG (and use all the same constants) but were implemented wrong. This is now fixed.
This makes pressure damage less aggressive. For example you now need to be at 20 kPa to start taking low pressure damage instead of 50 kPa. The HUD alerts severity 1 now mean "warning" like they're supposed to instead of actual danger. High pressure damage scales slightly differently (starts less aggressive).
Also minor change to air alarms (why I started looking at this in the first place).
Why / Balance
I couldn't help but notice the "warning" alerts started showing up even if you were already taking pressure damage... then I started loudly cursing because the barotrauma code uses the WARNING thresholds for actual damage...
Technical details
See commits.
Media
- [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
Changelog
:cl:
- fix: Fixed pressure damage calculations to what they were always supposed to be. This means pressure damage now starts happening at more extreme values (20 kPa for low pressure damage instead of 50 kPa) and high pressure damage is scaled different. It also fixed the HUD alerts so that the "warning" alerts show up before you actually start taking damage.
- tweak: Air alarms now start complaining about low pressure much earlier, when the pressure drops so much that you can't breathe oxygen tank.
