Birdogical Ascendence (Do Not Merge)

[Raikyr0]

Description

This is a test PR to see if one could replace limbs with biological ones instead of cybernetics using the component.

This is an affront to god.

This trait swaps your arms out for Harpy Wings. There's no way to customize wing color, markings or anything. However this should enable Harpy Flight.

Changelog

:cl:

• add: I profane gods creation and spit in his face, trait that replaces your arms with Harpy Wings.

[VMSolidus]

HYSTERICAL EVIL LAUGHTER

[coderabbitai[bot]]

Walkthrough

A new "Wings" trait has been introduced into the game's trait system. This addition includes both localization entries for the trait's name and description in English, as well as a corresponding trait definition in the physical traits prototype file. The trait is exclusive to non-Harpy and non-Xelthia species, and cannot be selected by characters with certain bionic arm traits. Mechanically, it replaces both arms with cybernetic wing limbs, granting the ability to fly like a Harpy.

Changes

File(s)	Change Summary
Resources/Locale/en-US/traits/traits.ftl	Added localization keys and description for the new "Wings" trait.
Resources/Prototypes/Traits/physical.yml	Defined the new "Wings" trait: point cost, eligibility requirements, and cybernetic arm-to-wing replacements.

Suggested labels

Status: Needs Review

Suggested reviewers

• angelofallars
• Remuchi
• Timfa2112
• OldDanceJacket

Poem

🪶
New wings unfurl in the trait parade,
Arms swapped for feathers, a bold upgrade!
Harpies may caw, but now you can soar,
Just don’t try this trick if you’re Xelthia or more.
Biesel’s code stands tall and neat—
Not a Sol Alliance bug in this feat!

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fdf07b7e39336b73b4e26f567b70e8781c90a6b2 and bbab2164c8b885175eb85b78d8c3b50426576bf1.

📒 Files selected for processing (1)

• Resources/Locale/en-US/traits/traits.ftl (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Resources/Locale/en-US/traits/traits.ftl

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: YAML Linter
• GitHub Check: build (ubuntu-latest)
• GitHub Check: YAML map schema validator
• GitHub Check: build (ubuntu-latest)
• GitHub Check: Test Packaging

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Raikyr0]

I should absolutely clarify that yes this is HILARIOUS, it definitely shouldn't be merged. It's a funny proof of concept though that it is indeed possible! When we get around to reworking Markings such that they can utilize CharacterRequirements, then we can actually absolutely revisit this trait!

Can't wait to steal tail dragging from Lizards if you have a tail Marking.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.