Ghost Role Stuff

[EctoplasmIsGood]

Description

This PR has some various changes, including disabling the xeno spawn event (they are INSANELY weak and are a boring event), tweaking other event chances, and making most weapons have the SentienceTarget component allowing them to become sentient ghostroles (they cannot actually do anything but talk so you can get the "officer your gun LITERALLY told me to take it")

Media

---

Changelog

:cl:

• remove: Xeno event is no more
• add: Most weapons can now become sentient through the random sentience event

[coderabbitai[bot]]

Walkthrough

This set of changes removes the custom DeltaV game event definitions, adjusts event weights and parameters in the main game rules, and introduces a new PirateRadioSpawn event. SentienceTarget components are systematically added to a wide range of weapon prototypes, including guns, melee weapons, and turrets, making them eligible for sentience-related events. The captain's sabre is specifically excluded from sentience targeting. The SlimesSpawn event is disabled, and several event occurrence rates are reduced to balance gameplay frequency.

Changes

File(s)	Change Summary
Resources/Prototypes/DeltaV/GameRules/events.yml	Deleted file. Removed all DeltaV-specific event entities: XenoVents, XenoVentsWeak, MothroachSpawn, PirateRadioSpawn.
Resources/Prototypes/GameRules/events.yml	Adjusted event weights and parameters for several station events; added new PirateRadioSpawn event; commented out SlimesSpawn event; increased maxSentiences for RandomSentience.
.../Weapons/Guns/Battery/battery_guns.yml .../LMGs/lmgs.yml .../Launchers/launchers.yml .../Pistols/pistols.yml .../Revolvers/revolvers.yml .../Rifles/rifles.yml .../SMGs/smgs.yml .../Shotguns/shotguns.yml .../Snipers/snipers.yml .../turrets/turrets_ballistic.yml .../turrets/turrets_base.yml	Added SentienceTarget component (flavorKind: station-event-random-sentience-flavor-inanimate, weight: 0.25) to base gun, turret, and shotgun entities. Minor whitespace cleanup in Snipers/snipers.yml.
.../Weapons/Melee/knife.yml	Added SentienceTarget component to BaseKnife.
.../Weapons/Melee/sword.yml	Added SentienceTarget to abstract Sword; removed SentienceTarget from captain's sabre.

Suggested labels

Changes: Sprite

Suggested reviewers

• Remuchi
• Timfa2112
• VMSolidus
• sleepyyapril

Poem

🛡️
In the barracks of code, we march in line,
Sentience for weapons—now that’s just fine!
The sabre stands alone, not to be awoken,
While pirate radios spark with signals unbroken.
Events rebalanced, critters swept away,
Biesel’s order prevails—Sol’s chaos kept at bay!
🦾

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9bba0cdc5e91aeae47cbbda3db43fde8b5916c99 and 8494d21b1709666f4f328ab480c32e976d262f02.

📒 Files selected for processing (1)

• Resources/Prototypes/GameRules/events.yml (8 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Resources/Prototypes/GameRules/events.yml

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Test Packaging
• GitHub Check: build (ubuntu-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: YAML Linter

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[EctoplasmIsGood]

Now I am become shitcoder, destroyer of balance

[EctoplasmIsGood]

I removed mothroach spawn so people take the mothroach pet ghost roles instead

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.