Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Engineering QoL Yaml Changes

Open WarMechanic opened this issue 8 months ago • 3 comments

Description

Engineering is a weird combination of being one of the most time-sensitive, while also being one of the slowest departments in the game. The eventual arrival of MODsuits will fix many of Engineering's slowness issues, however until then - Engineers gain the ability to place APCs from their RCD to reduce the number of round trips that need to be made which compounds their slowness.

There's also other QoL changes which I've personally wanted for a long time, generally automation focused.


TODO

  • [x] Adds Light Replacer to utility belt whitelist

  • [x] RCDs can construct APCs for 4 compressed matter

  • [x] RPDs can construct Air Alarms for 4 compressed matter

  • [x] Engivends gain the contents of bulk cable crates. 2 LV, 2 MV, and 2 HV cable coils. Copper as a resource makes cables scarcer.

  • [x] Adjust some wallmounteds to be constructible on the floor (fixes bad interaction of constructing wall, placing key automation device before deconstructing wall)

    • Air Alarms
    • Signal buttons
  • [ ] add yml media...


Media

todo


Changelog

:cl:

  • add: RCDs can now place APCs, and RPDs can now place Air Alarms
  • tweak: Light replacers can now be placed on your utility belt
  • tweak: Engivends now contain an additional 2 coils of each cable type, in case your station doesn't have a bulk cable crate
  • tweak: It is no longer mandatory to place air alarms and signal buttons on walls.

WarMechanic avatar Apr 19 '25 05:04 WarMechanic

Walkthrough

This update introduces several modifications to prototype and construction configuration files. New cable stack items have been added to the engineering vending machine inventory. The utility and chief engineer belts can now store light replacers. The RCD and RPD tools gain new construction targets: the APC and Air Alarm, respectively, with corresponding prototype entries added. Construction recipes for various switches, alarms, and timers have had their wall-mounting condition requirements removed, altering their placement constraints but not their core logic or structure.

Changes

Files/Paths Change Summary
Resources/Prototypes/Catalog/VendingMachines/Inventories/engivend.yml Added CableApcStack, CableMVStack, and CableHVStack (qty 2 each) to EngiVendInventory's starting inventory.
Resources/Prototypes/Entities/Clothing/Belt/belts.yml Added LightReplacer to whitelist tags for ClothingBeltUtility and ClothingBeltChiefEngineer storage.
Resources/Prototypes/Entities/Objects/Tools/tools.yml Added BaseAPC to RCD's availablePrototypes; added AirAlarm to RPD's availablePrototypes.
Resources/Prototypes/RCD/rcd.yml Introduced new RCD prototype entry for BaseAPC under Electrical category.
Resources/Prototypes/RPD/rpd.yml Introduced new RCD prototype entry for AirAlarm under Vents category.
Resources/Prototypes/Recipes/Construction/machines.yml Removed WallmountCondition from switch and button construction prototypes.
Resources/Prototypes/Recipes/Construction/utilities.yml Removed WallmountCondition from air alarm, fire alarm, and screen timer construction prototypes.

Suggested reviewers

  • Remuchi
  • OldDanceJacket
  • angelofallars

Poem

🚧
In the halls of Tau Ceti, new cables now vend,
Belts hold bright replacers, their storage extends.
RCD and RPD build with newfound delight,
No more wall-bound switches—place them left and right!
Alarms and timers freed from their mounting decree,
Such order and progress, as any officer would see.
🛠️


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c840f7c7d1e70b2b1b696bb11dfacf0f1e25cd49 and 560c9940788a2412b7675d54a881669f12af8c69.

📒 Files selected for processing (1)
  • Resources/Prototypes/Entities/Clothing/Belt/belts.yml (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • Resources/Prototypes/Entities/Clothing/Belt/belts.yml
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: Test Packaging
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: YAML map schema validator
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: YAML Linter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 19 '25 11:04 coderabbitai[bot]

:D

mrs-teg avatar Apr 20 '25 09:04 mrs-teg

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 10 '25 08:07 github-actions[bot]