Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Mirror: Fix StrippableSystem blunders

Open SimpleStation14 opened this issue 10 months ago • 0 comments

Mirror of PR #26166: Fix StrippableSystem blunders from space-wizards space-wizards/space-station-14

8ecb78ee5ac879ef0c79e9c35f3d05e72faf72fd

PR opened by Krunklehorn at 2024-03-16 02:33:20 UTC


PR changed 2 files with 13 additions and 7 deletions.

The PR had the following labels:


Original Body

About the PR

#25994 wasn't airtight. I never thought to test on animals, zombies or dead / crit players.

This PR fixes the following issues: #26144 #26145 #26150

  • Zombies and animals couldn't be stripped because I was checking for target hands too early
  • Dead/Crit was instantly stripping because I turned the strip time multiplier into a TimeSpan

Media

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Krunk

  • fix: Zombies and animals can be stripped once again.
  • fix: Dead or critical mobs can no longer be stripped instantly.

SimpleStation14 avatar Apr 22 '24 09:04 SimpleStation14