Psionically Insulates the Elite, Juggernaut, & Dreadnought Suits

[Yarinoi]

Description

Not much to explain here that isn't explained in the title? As said in the suggestion that caused me to make this PR; "It is... hilarious how easily you can lock down what was supposedly to be a major threat with something like a Mass Sleep or Mind Swap." So now, given the nukies are willing to splurge a little, not anymore.

---

TODO

• [x] Insulate the suits
• [ ] Make sure it works

---

Media

---

Changelog

:cl:

• add: Elite, Juggernaut, & Dreadnought hardsuits now have psionic insulation.

[coderabbitai[bot]]

Walkthrough

The changes introduce a new component type, TinfoilHat, to specific hardsuit helmet entities. The Syndicate Elite and Wizard hardsuits receive this addition in one file, while the Dreadnought hardsuit gains the component immediately after the FlashImmunity entry in another file. No existing components were modified or removed, maintaining the integrity of the hardsuit functionality.

Changes

File	Change Summary
Resources/.../hardsuit-helmets.yml	Added TinfoilHat component to Syndicate Elite and Wizard hardsuit helmet entities.
Resources/.../_Goobstation/.../hardsuit-helmets.yml	Added TinfoilHat component to the Dreadnought hardsuit helmet entity after the FlashImmunity component.

Poem

In the void, a new shield is cast,
A Tinfoil crown built to last.
Syndicate and Wizard now don this art,
Dreadnought's helm gains its stellar part.
Our code stands firm against Sol Alliance blight,
Marching boldly through the cosmic night!

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc5bd35d08534242ea4f0fc11f8fba4f443b5b7f and d17718b8fa9681e9c448d111c91ea2f1518e71b8.

📒 Files selected for processing (2)

• Resources/Prototypes/Entities/Clothing/Head/hardsuit-helmets.yml (2 hunks)
• Resources/Prototypes/_Goobstation/Entities/Clothing/Head/hardsuit-helmets.yml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• Resources/Prototypes/Entities/Clothing/Head/hardsuit-helmets.yml
• Resources/Prototypes/_Goobstation/Entities/Clothing/Head/hardsuit-helmets.yml

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: YAML Linter
• GitHub Check: Test Packaging
• GitHub Check: build (ubuntu-latest)
• GitHub Check: build (ubuntu-latest)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Tirochora]

I don't think this is a very good idea, frankly, as fully insulating all of the suits seems a bit much (it also prevents any chance of the nukies using psionics themselves) - it's been discussed on other servers, and while I'm in no position of power on this one I believe there are healthier ways to handle this. The cryptobiolin injector is the most common one I have seen, which is exactly what it sounds like: a small auto-injector akin to the stimulant ones that puts cryptobiolin in your bloodstream (where that chemical psionically insulates you for 15 minutes per dosage). Agents can manufacture cryptobiolin themselves, though it aforementioned injector is usually an uplink item.

[Yarinoi]

I don't think this is a very good idea, frankly, as fully insulating all of the suits seems a bit much (it also prevents any chance of the nukies using psionics themselves) - it's been discussed on other servers, and while I'm in no position of power on this one I believe there are healthier ways to handle this. The cryptobiolin injector is the most common one I have seen, which is exactly what it sounds like: a small auto-injector akin to the stimulant ones that puts cryptobiolin in your bloodstream (where that chemical psionically insulates you for 15 minutes per dosage). Agents can manufacture cryptobiolin themselves, though it aforementioned injector is usually an uplink item.

not all of the suits have been insulated, just the elite, juggernaut, and dreadnought ones, so only the nukies willing to spend that extra bit of telecrystals will get it, which also means that nukies can still use psionics because the ordinary bloodreds & its variants are unchanged. secondly, psionics are still really good. like the suggestion said, if you get mindswapped or mass sleeped, it's basically instantly over for you, especially in the case of the former. you could mindswap into a nukie and immediately start trying to beat yourself into crit, or just pop the acidifier implant if you dont care about dying, or even worse, immediately rush their friends, and there isnt much the nukie can do to stop you besides twiddle their thumbs and hope they can salvage the situation after the 20 seconds is over as for the injector idea, i do think it's interesting, though i'd like to know: do you have to manually activate it or can it be automatically triggered in response to psionics being used? because if it's the former, again, little stopping a min size shadowkin from sneaking up to a nukie and just mindswapping them after their cryptobiolin has run out, i think lastly, even if we do go ahead with the auto-injector idea, i still think at least the dreadnought should have psionic insulation since the whole point of it is giving the middle finger to anything that might try to kill you

[Yarinoi]

Actually this'll cause problems if you're not setting the TinfoilHat datafields for passthrough and DestroyOnFry

ah, shit.

[VMSolidus]

the passthrough datafield lets you cast psionics while wearing the helmet.

The destroyOnFry datafield causes the helmet to be turned into ashes if you're wearing it during a noospheric zap event. This is extremely bad for hardsuit helmets, and must be disabled on them.

[Yarinoi]

deliberately keeping passthrough off since i think not being able to cast psionics in exchange for immunity to them is a fair trade. other then that, should be all good

[Tirochora]

I don't think this is a very good idea, frankly, as fully insulating all of the suits seems a bit much (it also prevents any chance of the nukies using psionics themselves) - it's been discussed on other servers, and while I'm in no position of power on this one I believe there are healthier ways to handle this. The cryptobiolin injector is the most common one I have seen, which is exactly what it sounds like: a small auto-injector akin to the stimulant ones that puts cryptobiolin in your bloodstream (where that chemical psionically insulates you for 15 minutes per dosage). Agents can manufacture cryptobiolin themselves, though it aforementioned injector is usually an uplink item.

not all of the suits have been insulated, just the elite, juggernaut, and dreadnought ones, so only the nukies willing to spend that extra bit of telecrystals will get it, which also means that nukies can still use psionics because the ordinary bloodreds & its variants are unchanged. secondly, psionics are still really good. like the suggestion said, if you get mindswapped or mass sleeped, it's basically instantly over for you, especially in the case of the former. you could mindswap into a nukie and immediately start trying to beat yourself into crit, or just pop the acidifier implant if you dont care about dying, or even worse, immediately rush their friends, and there isnt much the nukie can do to stop you besides twiddle their thumbs and hope they can salvage the situation after the 20 seconds is over as for the injector idea, i do think it's interesting, though i'd like to know: do you have to manually activate it or can it be automatically triggered in response to psionics being used? because if it's the former, again, little stopping a min size shadowkin from sneaking up to a nukie and just mindswapping them after their cryptobiolin has run out, i think lastly, even if we do go ahead with the auto-injector idea, i still think at least the dreadnought should have psionic insulation since the whole point of it is giving the middle finger to anything that might try to kill you

Alright, yeah, you bring up valid points. The dreadnought suit, at the very least, would make sense to be psionically insulated (as you did say, it's meant to be the middle finger to basically everything). Here's my idea, though: I can probably add a normal injector pretty easily, I'll have to look about the auto-injector further. But... what if we either took specifically one of the suits (or made a new one, theoretically) that does have the passthrough component specifically for psionic situations? It would fall in line with most of the operative suits being catered towards specific scenarios, in this case if the operative themself is a powerful psion.

[Yarinoi]

Alright, yeah, you bring up valid points. The dreadnought suit, at the very least, would make sense to be psionically insulated (as you did say, it's meant to be the middle finger to basically everything). Here's my idea, though: I can probably add a normal injector pretty easily, I'll have to look about the auto-injector further. But... what if we either took specifically one of the suits (or made a new one, theoretically) that does have the passthrough component specifically for psionic situations? It would fall in line with most of the operative suits being catered towards specific scenarios, in this case if the operative themself is a powerful psion.

honestly, i really like the idea of having a specifically for-psions hardsuit, but i think it'll need some additional work beforehand. mostly a way for nukies to actually obtain psionics besides, god forbid, being a shadowkin and im glad we could compromise on the dreadnought suit, but i'll admit im still kind of iffy about not giving the other hardsuits psionic insulation

[Tirochora]

I believe seeing it on what you've suggested (elite, jugsuit, dreadnought) is reasonable until more specific anti-psionic implements are added (but I do think it should be revisited once that happens).

[BlueHNT]

So, you insinuate that we can make more psionic passthroughs to let certain types of psi-abilities through? Could make a thread on discord to see people's ideas on handling this as there will definitely be more than just 1, or a simple one for "mass ones" and "the rest"

Most likely gonna be classified in ways such as "Mental" "Elemental" "Telekinetic" and so on with Major/Minor definitions for that kind of stuff to work well. It would also be good for the lore I assume as this has to get worked in at some point more than just "psionically challenged or gifted species". Even security struggles with some of these abilities often and ends up with people being executed for pranks.

[Yarinoi]

So, you insinuate that we can make more psionic passthroughs to let certain types of psi-abilities through? Could make a thread on discord to see people's ideas on handling this as there will definitely be more than just 1, or a simple one for "mass ones" and "the rest"

Most likely gonna be classified in ways such as "Mental" "Elemental" "Telekinetic" and so on with Major/Minor definitions for that kind of stuff to work well. It would also be good for the lore I assume as this has to get worked in at some point more than just "psionically challenged or gifted species". Even security struggles with some of these abilities often and ends up with people being executed for pranks.

i dont think i've insinuated that. or at least, i havent been trying to, LMAO. and while your suggestion is mildly interesting, i think it's beyond my capabilities as a ""coder"".

outside of that, ETA on this being merged?

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.