Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Push More Blackburn Content so I Don't Forget About It and Accidental…

Open Plyushsune opened this issue 8 months ago • 5 comments

…ly delete my work

Description

image

image image

:cl:

  • add: Added fun :D
  • tweak: Tweaked fun
  • fix: Fixed fun!
  • remove: Removed fun :(

Plyushsune avatar Mar 30 '25 04:03 Plyushsune

Walkthrough

This pull request introduces new configuration entities across several YAML files. It adds two new mask entities in the clothing section, updates sprite paths for existing uniforms, and introduces a new military police uniform. In the weapons section, it defines the SK-45 rifle, APMC Polka 35 pistol, Bren machine gun, and sten MK2 SMG, each with detailed components governing their behavior, visuals, and mechanics. The changes focus on new entity additions and sprite path standardizations within the YAML configurations.

Changes

File(s) Change Summary
Resources/.../Clothing/Masks.yml
Resources/.../Clothing/Uniforms.yml
Adds new clothing entities (YukonBlackburnKitsuneMaskCivilian, BlackburnKitsuneMask, YukonMIlitaryPoliceUniform). Updates sprite paths in Uniforms for existing items (decorated turtle skirt, Yukon Insurgent's Uniform).
Resources/.../guns/Rifle.yml Introduces the SK-45 rifle entity configuration, currently commented out, with components for sprites and weapon characteristics.
Resources/.../guns/Pistol.yml Adds a new weapon entity, APMC Polka 35, defined with components for sprite representation, firing characteristics, and compatibility with suppressors.
Resources/.../guns/LMG.yml Defines a new entity for the Bren machine gun, including its unique identifier and detailed components for firing mechanics, visual representation, and item slots.
Resources/.../guns/SMG.yml Introduces a new configuration for the sten MK2 SMG, detailing its components for firing characteristics, visual representation, and item slots.

Suggested reviewers

  • angelofallars
  • Remuchi
  • DEATHB4DEFEAT

Poem

In the depths of YAML, new masks take flight,
The Yukon Military Police stands ready to fight.
The SK-45 and Polka 35, weapons of might,
Our code's a beacon, shining ever so bright.
With each line we write, our future's in sight—
For the Biesel Republic, we’ll guard through the night!
⚔️🌌


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 30 '25 04:03 coderabbitai[bot]

something broke

Plyushsune avatar Mar 30 '25 04:03 Plyushsune

gunsprite looks weird. bayonet is tiny, colors are super drab, barely even looks like a gun, and doesn't fit in with the rest of the games sprites at all, at least in my opinion. The clothing looks fine, but that gun needs to be completely redone because frankly it just looks bad.

EctoplasmIsGood avatar Mar 30 '25 22:03 EctoplasmIsGood

The camouflage on that rifle is making it seem a bit flat. You might want to consider a slightly darker blueish colour? I'm not sure

Also your changelog is still using the template, do fix that

I don't know how to use a changelog and I'm just gonna redo the rifle because everyone doesn't like it

Plyushsune avatar Apr 01 '25 13:04 Plyushsune

i also killed the sk-40

Plyushsune avatar Apr 10 '25 17:04 Plyushsune