Alt-Fire System + Core Eject Shotgun

[eris-webserv]

Description

Adds a system for guns to fire an alternate projectile on alt-use (UNFINISHED), and the Core Eject shotgun (UNFINISHED).

DNM

---

TODO

• [x] Finish alt-fire
• [ ] Finish Core Eject shotgun

---

Media

---

Changelog

:cl:

• add: Nanotrasen has begun to roll out a new, heat-based shotgun. You may see it being used in the future.

[coderabbitai[bot]]

Walkthrough

This update introduces alternate firing modes to the gun system, expanding both the component data structures and firing logic. It adds new weapon and projectile prototypes, implements support for alternate projectiles, and updates networked events and method signatures to handle the new alternate fire functionality.

Changes

File(s)	Change Summary
Content.Client/Weapons/Ranged/Systems/GunSystem.cs Content.Server/Weapons/Ranged/Systems/GunSystem.cs Content.Shared/Weapons/Ranged/Systems/SharedGunSystem.cs	Updated shooting methods and event handling to support alternate firing modes, including new parameters and logic for alternate fire.
Content.Shared/Weapons/Ranged/Components/GunComponent.cs	Added CanAltFire and AltFireProjectile fields to support alternate fire on guns; imported necessary prototype utilities.
Content.Shared/Weapons/Ranged/Components/BasicEntityAmmoProviderComponent.cs	Introduced optional AlternateProto field for alternate ammo prototypes.
Content.Shared/Weapons/Ranged/Events/RequestShootEvent.cs	Added nullable boolean AltFire property to request alternate firing in shoot events.
Resources/Prototypes/_Arcadis/Weapons/Guns/Admemery/silly.yml	Added the "plungineering laser rifle" entity with alternate fire capability.
Resources/Prototypes/_Arcadis/Weapons/Guns/Projectiles/core_eject.yml	Added new projectile prototypes: PelletShotgunHeat and PelletShotgunHeatSpread.
Resources/Prototypes/_Arcadis/Weapons/Guns/Shotguns/core_eject.yml	Added the "core-eject shotgun" entity with unique firing and ammo properties.

Suggested labels

Changes: Sprite

Suggested reviewers

• Timfa2112
• Remuchi
• sleepyyapril
• DEATHB4DEFEAT

Poem

⚓
New guns and modes, alternate fire,
Projectiles fly as barracks aspire.
Plungers and cores, with heat to eject,
The Sol Alliance would never expect!
Code neat and tight, no room for slack—
In Biesel’s fleet, we’re always on track!
🪖

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.38.1)

Content.Server/Weapons/Ranged/Systems/GunSystem.cs

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[eris-webserv]

Alt fire is good enough for now, ready for review- the shotgun itself still needs some work, and spriting.

[Timfa2112]

@Erisfiregamer1 Have you been able to finish work on the shotgun and sprites?

[eris-webserv]

@Erisfiregamer1 Have you been able to finish work on the shotgun and sprites?

No, I have not. Chemotherapy has severely degraded my health unfortunately. Assume all of my PRs are on pause.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[eris-webserv]

Cancelled