Synthesis Specialist, Fugitive, Syndicate Recruiter, and Antag Updates

[sleepyyapril]

Description

Ports fugitives, syndicate recruiters, and synthesis specialists Ports the updates to make them work Changes a lot of how antags work to make them cleaner. I might've changed something on accident, do check it over.

---

Changelog

:cl: Deltanedas, Lyndomen, and sleepyyapril

• add: Ported Syndicate Recruiter, Fugitive, and Synthesis Specialists

[github-actions[bot]]

RSI Diff Bot; head commit 24cc871aae575864611c14f498b3ffcc3cece3fb merging into e82ab3f6d2cb16b9b8f779d26bf62efdb9d750d2 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Misc/recruiter_pen.rsi

State	Old	New	Status
empty			Added
filled-1			Added

Edit: diff updated after 24cc871aae575864611c14f498b3ffcc3cece3fb

[VMSolidus]

Oh this PR is missing the MindRoles PR from Wizden. Which those are expecting.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Lyndomen]

can you credit deltanedas and myself too

[coderabbitai[bot]]

Walkthrough

This pull request introduces several new components, systems, and entity definitions for recruiter, thief, and fugitive functionalities. It adds client- and server-side recruiter pen systems with blood transfer and recruitment logic, updates UI logic for the thief backpack, and adjusts constants to dynamic configurations. New components and systems are added for recruiting conditions and fugitive event management. Localization files, datasets, and game rules have also been expanded and modified to support new roles, objectives, and shuttle setups.

Changes

File(s)	Change Summary
Content.Client/DeltaV/Recruiter/RecruiterPenSystem.cs Content.Server/DeltaV/Recruiter/RecruiterPenSystem.cs Content.Shared/DeltaV/Recruiter/RecruiterPenComponent.cs Content.Shared/DeltaV/Recruiter/SharedRecruiterPenSystem.cs Content.Shared/DeltaV/Roles/RecruiterRole.cs	Introduced new recruiter pen systems and components for handling blood drawing, recruitment processes, and role binding on both client and server sides.
Content.Server/DeltaV/Objectives/Components/RecruitingConditionComponent.cs Content.Server/DeltaV/Objectives/Systems/RecruitingConditionSystem.cs	Added a recruiting condition component and system to track and calculate objective progress based on recruited counts.
Content.Client/Thief/ThiefBackpackMenu.xaml Content.Client/Thief/ThiefBackpackMenu.xaml.cs Content.Server/Thief/Components/ThiefUndeterminedBackpackComponent.cs Content.Server/Thief/Systems/ThiefUndeterminedBackpackSystem.cs Resources/Locale/en-US/thief/backpack.ftl	Updated the thief backpack UI by replacing hardcoded text with dynamic labels, and switched from a constant limitation to a configurable property for maximum selected sets.
Content.Server/DeltaV/StationEvents/Components/FugitiveRuleComponent.cs Content.Server/DeltaV/StationEvents/Events/FugitiveRule.cs Content.Server/Roles/FugitiveRoleComponent.cs	Introduced fugitive role and event components to handle announcements, report generation, and event triggers associated with fugitive gameplay.
Content.Shared/Chemistry/EntitySystems/SolutionTransferSystem.cs	Modified method call to use AddSolution instead of Refill, allowing solution transfers without requiring refillable components.
Content.Shared/DeltaV/Paper/SignatureEvents.cs	Added a new record struct to represent sign attempt events with cancellation logic.
Content.Shared/DeltaV/Roles/SynthesisRole.cs	Introduced a synthesis role component as a new exclusive antagonist role.
Resources/Locale/ (multiple files: antags.ftl, fugitive/sets.ftl, game-ticking/game-rules/rule-fugitive.ftl, ghost/roles/ghost-role-component.ftl, objectives/conditions/recruiter.ftl, recruiter/pen.ftl, recruiter/recruiter.ftl, synthesis/synthesis.ftl)	Expanded localization with new entries for antagonist roles, fugitive kits, recruiter pen interactions, objectives, and dynamic text placeholders.
Resources/Prototypes/DeltaV/Catalog/fugitive_sets.yml Resources/Prototypes/DeltaV/Datasets/fugitive_crimes.yml Resources/Prototypes/DeltaV/Entities/Objects/Misc/paper.yml Resources/Prototypes/DeltaV/Entities/Objects/Specific/fugitive.yml Resources/Prototypes/DeltaV/Entities/Objects/Specific/recruiter.yml	Added new datasets and entity definitions including fugitive report, fugitive stash, and a recruiter's pen with detailed visual and functional components.
Resources/Prototypes/DeltaV/GameRules/events.yml Resources/Prototypes/DeltaV/GameRules/midround.yml (deleted) Resources/Prototypes/DeltaV/Objectives/fugitive.yml Resources/Prototypes/DeltaV/Objectives/recruiter.yml Resources/Prototypes/DeltaV/Objectives/synthesis_specialist.yml Resources/Prototypes/DeltaV/Roles/Antags/fugitive.yml Resources/Prototypes/DeltaV/Roles/Antags/recruiter.yml Resources/Prototypes/DeltaV/Roles/Antags/synthesis_specialist.yml Resources/Prototypes/DeltaV/Shuttles/recruiter.yml Resources/Prototypes/DeltaV/Shuttles/synthesis.yml	Expanded mid-round antagonist mechanics with new game rules, objectives, roles, and shuttle setups for fugitive, recruiter, and synthesis specialist antagonists.
Resources/Prototypes/Entities/Markers/Spawners/ghost_roles.yml Resources/Prototypes/Entities/Objects/Specific/Service/vending_machine_restock.yml Resources/Prototypes/Entities/Structures/Machines/vending_machines.yml Resources/Prototypes/GameRules/events.yml (SleeperAgents update) Resources/Prototypes/GameRules/unknown_shuttles.yml Resources/Prototypes/Nyanotrasen/Entities/Markers/Spawners/ghost_roles.yml Resources/Prototypes/radio_channels.yml	Made miscellaneous infrastructure adjustments including spawner modifications, inventory expansions for vending machines, event blacklist updates, addition of spawn categories, and radio channel color update.

Suggested reviewers

• sleepyyapril
• Remuchi
• DEATHB4DEFEAT

Poem

In the void of space our code must gleam,
Recruiter pens etch logic like a laser beam.
Thief backpacks now adjust with grace,
While fugitive roles announce their place.
Systems and rules, honed sharp as bayonets,
Stand ready—no Sol Alliance shall breach these,
Fresh recruits, keep your code as tight as space!

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.