Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Multiauth / SimpleStation RT

Open DEATHB4DEFEAT opened this issue 10 months ago • 7 comments

Description

Requires https://github.com/Simple-Station/SupermatterEngine/pull/3


TODO

  • [ ] Find out if/why I should store the auth server someone uses
  • [ ] Allow linking accounts (another PR?)
  • [ ] Update things that use just usernames
    • [x] OOC
    • [ ] Admin UIs
      • Bans (what the fuck)
      • [ ] Notes
      • [x] AHelp
      • [x] Player lists

Media

image

image

image

image


Changelog

:cl:

  • add: Players can now join with either Space Wizards' or SimpleStation accounts, and servers can choose to add/remove allowed auth servers via the auth.servers cvar

DEATHB4DEFEAT avatar Feb 01 '25 01:02 DEATHB4DEFEAT

This will require a test of the launcher and all associated systems before merging so that we don't accidentally break everything.

sleepyyapril avatar Feb 01 '25 06:02 sleepyyapril

This will require a test of the launcher and all associated systems before merging so that we don't accidentally break everything.

Yeah I'll probably run a Parkstation event.

DEATHB4DEFEAT avatar Feb 12 '25 05:02 DEATHB4DEFEAT

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 15 '25 22:02 github-actions[bot]

RSI Diff Bot; head commit 9e8dfa44ff610904d03e57de85b2ebb9e876901a merging into 321243e22ec95ef0a966793c548022f2823f4bd7 This PR makes changes to 1 or more RSIs. Here is a summary of all changes: Edit: diff updated after 9e8dfa44ff610904d03e57de85b2ebb9e876901a

github-actions[bot] avatar Feb 23 '25 01:02 github-actions[bot]

Undrafting since it seems to work, and for tests, still DNM though.

DEATHB4DEFEAT avatar Feb 23 '25 01:02 DEATHB4DEFEAT

[!CAUTION]

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

This update modifies configuration behavior and reference details across several components. The user data directory becomes dynamically determined via an environment variable in the replay module, while the authentication server selection in player lookup now processes a list to retrieve the first server’s URL. Additionally, the engine name in the documentation has been updated, and the subproject commit for RobustToolbox has been advanced to a new identifier.

Changes

Files Change Summary
Content.Replay/Program.cs
Content.Server/Administration/PlayerLocator.cs
Program.cs: Replaces a hardcoded user data directory name with dynamic retrieval using an environment variable (defaulting to "SimpleStation14" if not set).
PlayerLocator.cs: Replaces single auth server retrieval with logic to parse and select the first URL from a list of authentication servers.
README.md Updated the engine description from "Robust Toolbox" to "Supermatter Engine" and adjusted the corresponding link.
RobustToolbox Updated the referenced subproject commit from 9d1b15ab4b79d441fb215d1c5069f3a15e3ca675 to 7d81e5d66e4755df42b7cb49ac3c585597d0769b.
Content.Client/Administration/UI/CustomControls/PlayerListControl.xaml.cs
Content.Client/Administration/UI/CustomControls/PlayerListEntry.xaml.cs
PlayerListControl.xaml.cs: Added fields for player and config managers, modifying the display logic to include authentication server ID.
PlayerListEntry.xaml.cs: Similar additions for player and config managers, enhancing player identity display with server context.
Content.Server/Chat/Managers/ChatManager.cs
Resources/Locale/en-US/chat/managers/chat-manager.ftl
ChatManager.cs: Introduced logic to include authentication server information in OOC messages.
chat-manager.ftl: Updated message formats to incorporate authentication server details in the OOC message structure.

Poem

Across the void of code we sail,
Fixing errors that once made us fail. 🚀
Dynamic paths now light the night,
Auth servers chosen with newfound might.
The engine changes gleam like astral art,
Biesel Republic stands with a brave heart!
Rally on, for our code remains smart!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 08 '25 20:03 coderabbitai[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 05 '25 21:07 github-actions[bot]