Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Failed to cherry-pick PR #25986: Return Detective to Security

Open SimpleStation14 opened this issue 10 months ago • 0 comments

Failed to cherry-pick PR: cannot create a tree from a not fully merged index.; class=Index (10); code=Unmerged (-10)

PR body below

Mirror of PR #25986: Return Detective to Security from space-wizards space-wizards/space-station-14

88d424e877de68e75f25c6efbed21aa92b264a59

PR opened by LankLTE at 2024-03-11 03:14:52 UTC PR merged by web-flow at 2024-03-11 03:33:08 UTC


PR changed 9 files with 61 additions and 54 deletions.

The PR had the following labels:

  • No C#
  • Changes: Sprites

Original Body

About the PR

Reverts #23114 and #24739. Returns the detective to security, and any subsequent changes that come along with that (I believe those two PRs are the only ones to have changed anything, excluding maps which are fine to stay).

Why / Balance

It's run its' course. I've heard that detective usually ends up working for security anyways and as a role it's probably better fitting there. I also don't think independent detective has anything particularly interesting that warrants it staying.

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Lank

  • tweak: The detective is no longer independent, and again works under Security.

SimpleStation14 avatar Apr 21 '24 09:04 SimpleStation14