Einstein-Engines icon indicating copy to clipboard operation
Einstein-Engines copied to clipboard

Mirror: Syringes that spawn with content start in inject mode

Open SimpleStation14 opened this issue 10 months ago • 1 comments

Mirror of PR #25881: Syringes that spawn with content start in inject mode from space-wizards space-wizards/space-station-14

5cb48c922fa7236d07b463f0c38ada2d5805e54b

PR opened by Plykiya at 2024-03-06 13:43:59 UTC PR merged by web-flow at 2024-03-09 10:19:03 UTC


PR changed 3 files with 25 additions and 23 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

Made it so that syringes that spawn with content start out in inject mode rather than draw mode. Also got rid of unnecessary DataField names if they matched.

Why / Balance

Grab bic syringe from medkit, use it on patient, it's in draw mode by default, cry.

Technical details

I added a new yml entity for prefilled syringes that starts in inject mode.

I attempted to do it the "smart way" by changing the ComponentInit code to check for the solution amount and toggle based on that, but for some reason the solution was returning false on the server-side but not on the client-side so there was a desync in the Inject state. Couldn't really figure out how to fix it, so I just went with the dumb simple method instead.

Media

  • [ X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None

Changelog

:cl:

  • tweak: Pre-filled syringes start in inject mode now.

SimpleStation14 avatar Apr 21 '24 09:04 SimpleStation14