simplQ-frontend icon indicating copy to clipboard operation
simplQ-frontend copied to clipboard

Home page makes unnecessery fetch requests

Open mradenovic opened this issue 4 years ago • 2 comments

For a single page app, there are too many fetch requests, e.g., ``home page will trigger getUserQueues almost every time it is rendered. Some of these issues are addressed in #544. I also identified a - couple of more places/events that trigger it:

  • [ ] On login - the app goes away and back to initiating page, causing a re-render. A possible solution is loginWithPopup.
  • [ ] On logout - app reloads origin page, causing another render. A possible solution is using different logout options.
  • [x] Clicking Home in navigation. Currently, the home button is just an HTML anchor. A possible solution is using router history.
  • [x] Clicking logo in the navbar, when current page is not home page. A possible solution TBD.

mradenovic avatar Feb 18 '21 19:02 mradenovic

Items 3 and 4 have been taken care of in #556

maaverik avatar Feb 28 '21 13:02 maaverik

I'm not sure if we should use popups for login. It could break for someone using some popup blocker, too much hassle.

Can we be excused just for the case of login/logout?

daltonfury42 avatar Mar 20 '21 10:03 daltonfury42