Šimon Woidig

Results 26 comments of Šimon Woidig

@sfc-gh-gmerticariu Yes, I have figured as much from the code. But I don't think this is the wanted behaviour. I would expect the unsealer to just look at the vault...

@sfc-gh-gmerticariu Yes I understand. But I have no idea, why there is even hostname resolving, since the resolved IP is overwritten by the pod IP(s).

> @nikola-jokic, @rteeling-evernorth , > > Since there is no intention no provide the capacity on ArgoCD. Could a possibility be around the support of annotations on all Kubernetes objects...

I am afraid not. I am not really experienced in Ruby.

Also would be nice, if the healthcheck contained the status of the connected killbill instance. But I guess it is not 100% required, since we can get the status from...

The docker image has the following command/CMD set: `[yarn,build-and-start]` which is then passed to the `docker-entrypoint.sh` that just executes that. The command should rather be `server.js` which then gets executed...

> @SimonWoidig > > No #1559 did not bring up that issue. > > Before V3 yarn build-and-start was the default command, to ensure when for example a user mapps...

I don't want to rush anyone, but the PR is ready I think and there are not that many changes. Would appreciate if anyone looked at it. Thank you!

> Awesome. Could you please mention `containerSecurityContext` field in the README? Besides that, looks good for me. @SimonWoidig Will do!

Sorry for the noise, but I've updated the readme. The description for the pod `securityContext` didn't make much sense to me but I didn't change it. For the `containerSecurityContext` I...