kcov icon indicating copy to clipboard operation
kcov copied to clipboard

Publish Dockerimage with versioned alpine tags?

Open jakub-bochenski opened this issue 9 months ago • 7 comments

As far as I can see there is only latest-alpine, but there is no 42-alpine tag

jakub-bochenski avatar May 29 '25 14:05 jakub-bochenski

It looks like it should push it, from the ci.yml. I also see that there's no v43 tag either. @williamdes do you know why it haven't been built?

SimonKagstrom avatar Jun 02 '25 12:06 SimonKagstrom

It looks like it should push it, from the ci.yml. I also see that there's no v43 tag either. @williamdes do you know why it haven't been built?

Well, it seems to have been skipped: https://github.com/SimonKagstrom/kcov/actions/runs/10064426641/job/27822055109 The condition on https://github.com/SimonKagstrom/kcov/blob/d8ca8d432f604a4addbfd9f288914e9882f415f8/.github/workflows/ci.yml#L155

Should be changed to add release tag refs

To mitigate this, can you click to manually dispatch a build for that tag ? Here is an example on my project:

Image

williamdes avatar Jun 02 '25 12:06 williamdes

I gave it a go @williamdes!

Unfortunately, the CI builds now fail due to other reasons (Homebrew versions on MacOS, unknown for me failures on the non-x86 Linux arches).

So you mean something like ${{ github.ref == 'refs/tags/XX' || ...? Not quite sure how to write that though.

SimonKagstrom avatar Jun 02 '25 17:06 SimonKagstrom

I gave it a go @williamdes!

Unfortunately, the CI builds now fail due to other reasons (Homebrew versions on MacOS, unknown for me failures on the non-x86 Linux arches).

So you mean something like ${{ github.ref == 'refs/tags/XX' || ...? Not quite sure how to write that though.

Hi @SimonKagstrom On a project I use if: startsWith(github.ref, 'refs/tags/production/')

So maybe you can try

- if: ${{ github.ref == 'refs/heads/master' || github.event_name == 'workflow_dispatch' }}
+ if: ${{ github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/v') || github.event_name == 'workflow_dispatch' }}

Will you do a release in the following days ?

williamdes avatar Sep 05 '25 09:09 williamdes

@williamdes not planning for a release right now. This branch has some changes to test your suggestion above! https://github.com/SimonKagstrom/kcov/tree/test-481-alpine-builds

SimonKagstrom avatar Sep 07 '25 08:09 SimonKagstrom

@williamdes not planning for a release right now. This branch has some changes to test your suggestion above! https://github.com/SimonKagstrom/kcov/tree/test-481-alpine-builds

The .yml diff looks fine No sure why build fails with __main__.py: error: unrecognized arguments: amd64 🤔

williamdes avatar Sep 08 '25 16:09 williamdes

Yeah... My stamina went completely out when I got that error :-/

SimonKagstrom avatar Sep 09 '25 17:09 SimonKagstrom