Simon Cropp

Span usage

1

have you considered using the new span APIs to get better perf and memory usage?

should settings parsing ignore invalid values?

2

should settings parsing ignore invalid values?  AB#2112231

related to https://github.com/microsoft/testfx/issues/2991

add ITypeDestructuringPolicy

1

IMO it is better to do the type checking once and cache it

allow comparer to be omitted in EqualityExtensions

1

it would seem the intent of AllAreTheSame is to allow people to omit passing a comparer ? given the defaulting of the comparer to a value ``` comparer ??= EqualityComparer.Default;...

what the policy on var?

1

currently there are places where type is apparent where var is not use ``` List operationConfigReaders = new List(componentManager.OfType()); ``` places where type is apparent where var is used ```...