Simon_CQK comments

Results 29 comments of


                                            Simon_CQK

[feature request] Integrating pod logs with SLS

@llinvokerl hi llinvokerl, would you contribute the proposed feature to the community? If so, I will assign it to you :)

Adding functionality to delete successfully completed jobs in a FIFO …

> @SimonCqk please review. nice work!

Adding functionality to delete successfully completed jobs in a FIFO …

@sbdtu5498 LGTM in my view, anyway, can you add some unit tests for this feature?

Adding functionality to delete successfully completed jobs in a FIFO …

> Sure thing! Also, do you think it would be a good idea to have two different historyLimit e.g. successfulHistoryLimit and failedHistoryLimit, to give more freedom to users over which...

Adding functionality to delete successfully completed jobs in a FIFO …

@sbdtu5498 hi, it seems that UT/e2e checks failed, would you rebase upstream master branch and add more tests, then the PR can move on!!

[feature request]I would like to monitor the kubedl_jobs_failed metric, but the label only supports kind and does not allow retrieving the jobName. The experience with exposed metrics is very unsatisfactory.

@13241308289 Hi, thanks for the feedback! The reason we didn't initially include this label was due to the limited capacity of Prometheus's data backend, which doesn't actively purge data that's...

[feature request]I would like to monitor the kubedl_jobs_failed metric, but the label only supports kind and does not allow retrieving the jobName. The experience with exposed metrics is very unsatisfactory.

> I took another look at the code, and it turns out that this metric is initialized at the controller layer, which is why it's not possible to expose the...

syncing rbac based yamls by manually updating all_in_one.yaml and generating latest helm files using make helm-chart

I'll review ASAP

syncing rbac based yamls by manually updating all_in_one.yaml and generating latest helm files using make helm-chart

btw, PR conflicts with master branch