Simon Biggs
Simon Biggs
> * I think we should support all orientations encoded in at least the DICOM coord system Yup, I think sticking to DICOM coordinates for now is enough to bite...
> Mmm... I'd prefer not to, but I'm not strongly opposed. I'm not strongly for. I just personally have a bit of an aversion to a lot of if/elif/else cases....
Are you able to do a diff between the last release and master? (GitHub let's you compare between commits) On Sun, 10 Dec 2023, 5:17 pm Matthew Jennings, ***@***.***> wrote:...
Hi @peterg1t, Your experimental graticule alignment code is also being caught up in this. See my message to Jake above. More than happy for the code to come back, but...
Hi @ayalalazaro, Your code has also managed to get caught up in this. You were using some deprecated and now removed numpy APIs. As such, the code is removed for...
Oh that sucks, given the name I believe it refers to this issue number: https://github.com/pymedphys/pymedphys/issues/1047 And probably this comment here: https://github.com/pymedphys/pymedphys/issues/1047#issuecomment-691389682 With this download URL: https://github.com/pymedphys/pymedphys/files/5212087/NPCA_Anonymised.zip Maybe the file needs...
Really doesn't matter where you upload it :) Just somewhere we trust
Hi @ayalalazaro, I'll make a PR for you that pulls your code back in, that way it should be much easier for you to fix. Let me do that for...
Thanks @laser47-hue!! @Matthew-Jennings, I believe @laser47-hue has fixed this issue over in https://github.com/pymedphys/pymedphys/pull/1828#pullrequestreview-1940959050 which is now merged.
Yup, don't hold back the release for pyright. That would definitely be the tail wagging the dog