Simon Biggs

Results 652 comments of Simon Biggs

A potential fix would be to have variable names need to be a parameter. It might be a helpful change, could eventually allow using the inside of the element to...

I imagine the first step would be to copy all of the tests over, then to implement flags that switch the notebook server to a kernel gateway. Update the tests...

I imagine the real first step is, if it is desired by you, would be to start the conversation over at the notebook server repo.

Or is the difference between using REST and websockets vs zeromq such a massive fork in the road that code base overlap in reality is actually minimal?

@rgbkrk I wasn't able to get CORS to work on the notebook server without also having the options "allow_headers" and "allow_methods" that kernel gateway provides. I gave a bit more...

@rgbkrk The meat of enabling `allow_headers` and `allow_methods` is within the CORSMixin class: https://github.com/jupyter/kernel_gateway/blob/fc1d714eecacacc4447ec516578d9032c1f2b574/kernel_gateway/mixins.py#L12-L43 Would you be okay with me attempting a pull request to include that class within the...

On second thoughts really there is probably a much more "notebook specific" way which essentially adds the following for `allow_headers` and `allow_methods`: https://github.com/jupyter/kernel_gateway/blob/fc1d714eecacacc4447ec516578d9032c1f2b574/kernel_gateway/mixins.py#L30-L33 I'll have a look more into the...

@rgbkrk Scrap that. Your suggestion worked. I had to turn off xsrf cookies, then using token access worked perfectly. https://github.com/jupyter/notebook/issues/2644

@kevin-bates thank you for the heads up. Massively appreciated. I'll take it for a spin on the weekend hopefully.