Simon Krajewski

Results 881 comments of Simon Krajewski

Could you reduce this example to what you actually mean? Locally this gives me ``` source/Main.hx:50: catch Error TEnum(haxe.io.Error) source/Main.hx:24: handle Error TEnum(haxe.io.Error) ``` This seems correct, but I'm confused...

There's a chance that this has been fixed in hxcpp already. You could try `haxelib git hxcpp https://github.com/HaxeFoundation/hxcpp` to test with the current version, which should be backwards-compatible.

@kLabz Could you check this with 4.3 and bisect it? I seem to remember some related fix but I can't find it.

It's not very easy to tell with this convoluted example, but I think development output is correct.

Both seem acceptable because depending on the target a value may or may not be wrapped in `ValueException`. I don't see how we could unify this unless we always wrap...

Didn't that PR just introduce the inconsistencies by avoiding the wrapping on some targets?

Hmm, I find this one more convincing than #11691 because the example looks more realistic... perhaps something could be done for this after all. It's pretty tricky though because we...

I can't really review this, but CI is green so I'll assume that it's good!

Like this? ``` C:\git\go2hx>go run . ./scripts/hxb . create check.json memory: 99 C:\git\go2hx>haxe create_hxb.hxml Type not found : github_com.go2hx.go4hx.scripts.hxb.Hxb ```

Ah nice, now it works (and reproduces) for me too.