Simon Krajewski

Results 882 comments of Simon Krajewski

Please define the environment variable `OCAMLRUNPARAM=b` and paste the stacktrace that it should print.

This might be difficult to investigate without seeing the code. The failing lookup is `ftable.(f.findex)`. I'm not very familiar with the code, but I think this must come from `cfids`...

@ncannasse Most of these `alloc_fun_path` calls look suspicious to me. They call `lookup ctx.cfids`, which might `DynArray.add` on `cfids`. That then increases the next ID, which is not going to...

This is technically correct because the call subject is the entire `EField` expression, not just the name. But I agree that it's quite stupid...

My fix for this doesn't work. I think the problem is that due to the potentially delayed nature of our typing, disabling the report mode like this might affect various...

The change causes some threads tests to fail: ``` cases.TestMainLoop testNewAction_immediately: ERROR O missed async calls: 1 testWorksInStaticInits_issue10114: ERROR O missed async calls: 1 ```

@RealyUniqueName @ncannasse I would appreciate if you could sort out this failing test because I'm not familiar with this code at all. This currently makes our CI red.

I'm guessing this is more complicated than just changing `libpcre3` to `libpcre2` in some places?

At times like this I realize that GitHub needs a crying emoji...

Indeed, while writing OCaml bindings isn't much fun, we're only using like 5 or so PCRE functions for which we would need bindings.