Simon Krajewski

Results 882 comments of Simon Krajewski

Hmm, I don't like properties that have hidden cost like that... Also, what's with this idiotic new GitHub feature about manually running PRs, wtf...

> To be fair, it's not really a hidden cost because you'd have to do it in Lua/Flash anyways (in other words, it's already a common pattern). Well yes, but...

I mean, ultimately the question becomes if we want this at all. What do people do with the size of maps? I never found this to be particularly useful.

Huh, I thought we already had some sort of `isEmpty` on maps, but apparently we don't. In that case I'm fine with the addition. It can probably also be useful...

Coming back to this, I can't really remember why I said that this was good but didn't merge it. Could you update the branch?

Let's do the following: 1. Factor out the ES6 changes for #9303 (without the `size` addition) because that's a good change in its own right. 2. Factor out the `size`...

With #11698 merged I'll go ahead and close here because I don't expect this to be updated.

Oh so that's what these `efk_todo` in typer.ml are about...

Changing this would probably break every IDE out there.

I'm not sure how much sense type parameter constraints make if the constrained type parameters only appear in the return value of a function.