audio_waveforms
audio_waveforms copied to clipboard
SimformSolutionsPvtLtd
Added bitrate selection
Fixed (Class 'AudioRecorder' is not abstract and does not implement abstract member public abstract fun onRequestPermissionsResult(p0: Int, p1: Array<(out) String!>, p2: IntArray): Boolean defined in io.flutter.plugin.common.PluginRegistry.RequestPermissionsResultListener) for Android.
Added bitRate feature for Android (Default to 64kbps)
Contains fix for https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/41
@abhay-s-rawat Can you please share what issues we might face if we allow users to set bit rate as you have added un-tested?
Actually I tested for Android but for IOS its not tested as I do not have access to xcode. It was a minor change anyways , I modified only a paramters after going through the library documentation. If by any chance you have access to xcode please use my forked version to debug https://github.com/abhay-s-rawat/audio_waveforms. or use audio_waveforms: git: url: https://github.com/abhay-s-rawat/audio_waveforms as dependency. Then just observe the file size with and without passing bitrate. Default is 32KBPS. (late int bitRate = 32768;) then use a bigger value.
Sorry for the fact that I do not have access to mac otherwise I would have tested in IOS too.
Can you please tell when you are planning to merge this request because I have to use the updates in my project , currently I am using my git copy in pubspec but I cannot use that when live.
Hi @abhay-s-rawat thanks for your contribution, We would like to merge your PR but we have already upgraded our package to flutter 3.0 and we have released the latest version 1.4.0, So please update your code with the latest changes by taking upstream in your forked repository so we can proceed further with the review. Also please squash all commits in the one as you have 5 commits for this change.