audio_waveforms icon indicating copy to clipboard operation
audio_waveforms copied to clipboard

Implemented: Move playhead position with waveform gesture `onTapDown`

Open p4-k4 opened this issue 2 years ago • 3 comments

I've implemented it, but have no idea how to make PR's (or operate git). Could this be considered?

When enableSeekGesture is set as true, this will move the playhead position even when playback is paused or stopped. Currently only moves playhead position whilst in a playing state.

audio_file_waveform.dart L214

        onTapDown: (details) async {
          if (widget.enableSeekGesture) {
            final _maxDuration = await widget.playerController.getDuration();
            _audioProgress = details.localPosition.dx / widget.size.width;
            setState(() {});
          }
        },

Cheers

p4-k4 avatar Mar 31 '23 07:03 p4-k4

@p4-k4 thank you for your suggestion. Your implemention works for only WaveformType.fitWidth so I will update the logic and will create a PR

ujas-m-simformsolutions avatar Apr 14 '23 06:04 ujas-m-simformsolutions

Any news about this update ?

pbaudri avatar Jul 04 '23 10:07 pbaudri

@ujas-m-simformsolutions any updates

alexboulay avatar Aug 21 '23 19:08 alexboulay