audio_waveforms icon indicating copy to clipboard operation
audio_waveforms copied to clipboard

enable seek gesture in paused mode

Open woolfman007 opened this issue 1 year ago • 6 comments

First of all, this is a fantastic package, excellent work! I'd suggest to enable seek gestures also when playback is paused. I changed that locally and it seems to work well:

in PlayerController.seekTo() I use

if (_playerState == PlayerState.playing || _playerState == PlayerState.paused)

instead of

if (_playerState == PlayerState.playing)

Also, seekTo() most of the time does not refresh the displayed waveform in that case. I can seekTo(0) and the next call to startPlayer() will correctly start from the beginning; however, the waveform position is not updated.

woolfman007 avatar Mar 25 '23 10:03 woolfman007

I can't get seekTo(0) to reset the waveform seek position at all actually.

p4-k4 avatar Mar 31 '23 02:03 p4-k4

@woolfman007 I've added the ability to specify whether or not the waveform resets its playhead position on my fork. See here:

https://github.com/SimformSolutionsPvtLtd/audio_waveforms/commit/8a46a4a984762960ef4ba9c1941ceadabab67466

I just have no idea how to use git to put in a PR lol

Somehow I managed to put in a PR for your other suggestion though: https://github.com/SimformSolutionsPvtLtd/audio_waveforms/pull/203

p4-k4 avatar Mar 31 '23 05:03 p4-k4

Would be nice to have this feature. @ujas-m-simformsolutions, do you plan to update the package anytime soon?

DevTello avatar Feb 15 '24 16:02 DevTello

Yes @DevTello, we are working on this and try to given update ASAP

himanshuGandhiSimform avatar Feb 23 '24 10:02 himanshuGandhiSimform

When is this fix expected to be released? Do you have any updates for us?

Thank you in advance for your help!

rubenRoehner avatar May 10 '24 07:05 rubenRoehner

When is this fix expected to be released? Do you have any updates for us?

Thank you in advance for your help!

We currently have one PR for this #272. But our next release will have some breaking changes so it might take some time to release a new version.

Ujas-Majithiya avatar May 10 '24 16:05 Ujas-Majithiya