Simen Bekkhus
Simen Bekkhus
Cool 👍 Enjoy your vacation! Ideally the reproduction is not the entire `@apollo/client` 😅
We looked at global config's root dir in v29 as well (have done for years). However, I do agree that seems odd 🤔 @brandon-leapyear thoughts on this one?
I honestly don't really understand why we have `rootDir` on both places 😅 _Just_ having it in `ProjectConfig` seems correct to me
I did start messing around with removing a bunch of config from `global` that should really be on `project`, but that quickly turned unwieldy. For `testPahPatterns`'s purposes though, we can...
@brandonchinn178 would you be able to send that PR? 🙂
Interesting! Do we know why it regressed so much in 18.13? As for mitigations, easiest is probably just to avoid shelling out at all. Maybe walking the file system looking...
FWIW, #14826 helps a bit _before_ the `findRepos` calls. I found https://github.com/antongolub/git-root - I wonder if we should use that? I'd assume just fixing `git` is enough as that's most...
bah, of course... Mixing VCS-es sounds horrible, but I bet we'd break _somebody_ if we looked for only looked for Mercurial and Sapling if we didn't find git roots. I...
We should start by adding a warning to the docs I guess, but it would be nice to support this
I like the idea! `jest.retryTimes({immediately: true})` or something? PR welcome 🙂