Simen Bekkhus comments

Results 1237 comments of


                                            Simen Bekkhus

[new-rule] prefer importing from @jest/globals

Note that you can run jest with [`injectGlobals: false`](https://jestjs.io/docs/configuration#injectglobals-boolean) and at least get runtime errors today. I doubt we'll ever change the default, but who knows 🙂 It's at least...

Export rule utilities

we can export them, sure. @G-Rath looked into it at some point I believe

Snap processor makes enforcing other rules on .snap files impossible

I'm afraid I don't understand the issue here >I think it ought to be configurable. Configurable in what way?

Snap processor makes enforcing other rules on .snap files impossible

Aha, gotcha. Wanna send a PR? I'm not sure how this is normally handled

Snap processor makes enforcing other rules on .snap files impossible

Happy to remove it if it's not needed. Give it a go? 😀

feat(expect-expect): support using wildcards in `additionalTestBlockFunctions`

is this one still alive? 🙂

fix: make no-jest-import error message more accurate

I'm fine with either wording, @G-Rath wdyt?

perf: cache jest fn call parsing results

> (@SimenB we should make sure that `pref` actually triggers a release before merging this 😅) It should trigger a patch release, looking at https://github.com/semantic-release/commit-analyzer/blob/ad3079b515be8266da02cc6dc64f765dd8aaf509/lib/default-release-rules.js#L12

[no-test-callback] doesn't handle `done` being used to fail a test

Bad example, should be ```js test('some test', done => { setTimeout(() => { expect(false).toBe(true); done(); }, 10); }); ``` You'd never use `done` in a synchronous test, as there's nothing...

Warn about tests not run by jest

Yeah, go for it!