Simen Bekkhus comments

Results 1237 comments of


                                            Simen Bekkhus

linebreak-style makes it impossible for Windows users to contribute

https://github.com/airbnb/javascript/issues/1089#issuecomment-254025333 Also, it should be set to `off`, not removed.

Support returning promises on Session prototype methods

What about adding `destroyAsync` etc next to the versions that takes callbacks? Would mirror what e.g. bluebird does when promisifying. (I couldn't see this mentioned in the linked issues/PRs, apologies...

Improve mismatched query error message

Now that `@apollo/react-testing` is its own package, bundle size shouldn't really be an issue anymore, should it? And of course I'm biased, but `jest-diff` is pretty good 😀 (I realise...

Types of things like `Document`, etc, seem not exported in v7

The linked PR only exported error codes - not sure why it closed this issue? Seems totally unrelated

TPM plugin for this would be cool.

:+1:

Conditional required env?

Ooooh, I like that idea! That's not supported now, but I for one would love to see a PR for it 🙂

Enforce directory casing in `filename-case`

IMO it should enforce the entire path (within cwd) regardless of files and folders. No option - you either care about consistent casing or not. Yes, a breaking change, but...

Enforce directory casing in `filename-case`

Exactly. Respect it's a breaking change, but don't let that stop us. (imo)

`request.url` is mutated between `onRequest` and `onResponse`

Aha! It was easiest for me to reduce my local error down using `fastify-express`, didn't think the issue was actually here

`request.url` is mutated between `onRequest` and `onResponse`

Add a `pinned` label or what it's called so the bot leaves it alone?