Simen Bekkhus

Results 1232 comments of Simen Bekkhus

Seems like a reasonable change to me 🙂 While I agree everything thrown should be a subclass of `Error`, we shouldn't make assumptions. Mind taking a look at the failing...

>My suggestion would be to support `toThrow` only in `rejects` and remove it from `resolve`. I think that makes sense! Or throw a useful "`toThrow` should only be used with...

@thymikee @rickhanlonii thoughts?

That's not really an option - if you want that Jest is not for you :) Almost all of the features in jest depends on the isolation (mocks, transformations, fake...

Sorry about the slow response on this! 😬 I don't think this is the correct approach, unfortunately - even though it might prove to be the only way to deal...

`follow-redirects` doesn't seem to overwrite anything on the core module. However, their copying logic fools the Proxy implementation in this PR. https://github.com/follow-redirects/follow-redirects/blob/633ffa89970806b44ec1721f60d0c16cfe79a267/index.js#L364-L368 Not sure about Sentry, they have so much...

I haven't looked into it, but it _seems_ like something that won't work since hoisting doesn't work for native ESM. https://jestjs.io/docs/ecmascript-modules#module-mocking-in-esm I.e. you need to use dynamic imports so the...

`unstable_mockModule` isn't hoisted fwiw. And yeah, we haven't implemented `jest.importActual` or something like it yet to be able to partially mock a module

> I should not get an error about using `localStorage` unless I'm meaningfully trying to use `localStorage` when it's forbidden. Jest isn't trying to use it either. Seems aggressive from...